mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/1] pwm: Use pr_* functions in pwm-samsung.c file
Date: Mon, 9 Jul 2012 08:27:07 +0200	[thread overview]
Message-ID: <20120709062707.GB10484@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1341566030-3902-1-git-send-email-sachin.kamat@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

On Fri, Jul 06, 2012 at 02:43:50PM +0530, Sachin Kamat wrote:
> Replace printk with pr_* functions to avoid checkpatch warnings.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/pwm/pwm-samsung.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

Applied, thanks,

Thierry

> 
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index 35fa0e8..d103865 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -11,6 +11,8 @@
>   * the Free Software Foundation; either version 2 of the License.
>  */
>  
> +#define pr_fmt(fmt) "pwm-samsung: " fmt
> +
>  #include <linux/export.h>
>  #include <linux/kernel.h>
>  #include <linux/platform_device.h>
> @@ -340,13 +342,13 @@ static int __init pwm_init(void)
>  	clk_scaler[1] = clk_get(NULL, "pwm-scaler1");
>  
>  	if (IS_ERR(clk_scaler[0]) || IS_ERR(clk_scaler[1])) {
> -		printk(KERN_ERR "%s: failed to get scaler clocks\n", __func__);
> +		pr_err("failed to get scaler clocks\n");
>  		return -EINVAL;
>  	}
>  
>  	ret = platform_driver_register(&s3c_pwm_driver);
>  	if (ret)
> -		printk(KERN_ERR "%s: failed to add pwm driver\n", __func__);
> +		pr_err("failed to add pwm driver\n");
>  
>  	return ret;
>  }
> -- 
> 1.7.4.1
> 
> 
> 

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-07-09  6:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06  9:13 Sachin Kamat
2012-07-09  6:27 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709062707.GB10484@avionic-0098.mockup.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®