From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [RFC][PATCH 3/4 v4] ftrace/x86: Remove function_trace_stop check from graph caller
Date: Wed, 11 Jul 2012 15:50:51 -0400 [thread overview]
Message-ID: <20120711195745.588538769@goodmis.org> (raw)
In-Reply-To: <20120711195048.885039013@goodmis.org>
[-- Attachment #1: 0003-ftrace-x86-Remove-function_trace_stop-check-from-gra.patch --]
[-- Type: text/plain, Size: 1090 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The graph caller is called by the mcount callers, which already does
the check against the function_trace_stop variable. No reason to
check it again.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/x86/kernel/entry_32.S | 3 ---
arch/x86/kernel/entry_64.S | 3 ---
2 files changed, 6 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 8ef138f..9019806 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -1232,9 +1232,6 @@ END(mcount)
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
ENTRY(ftrace_graph_caller)
- cmpl $0, function_trace_stop
- jne ftrace_stub
-
pushl %eax
pushl %ecx
pushl %edx
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
index 52bda2e..38308fa 100644
--- a/arch/x86/kernel/entry_64.S
+++ b/arch/x86/kernel/entry_64.S
@@ -213,9 +213,6 @@ END(mcount)
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
ENTRY(ftrace_graph_caller)
- cmpl $0, function_trace_stop
- jne ftrace_stub
-
MCOUNT_SAVE_FRAME
leaq 8(%rbp), %rdi
--
1.7.10
next prev parent reply other threads:[~2012-07-11 19:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 19:50 [RFC][PATCH 0/4 v4] ftrace/kprobes: Setting up ftrace for kprobes Steven Rostedt
2012-07-11 19:50 ` [RFC][PATCH 1/4 v4] ftrace/x86: Add separate function to save regs Steven Rostedt
2012-07-12 12:12 ` Masami Hiramatsu
2012-07-11 19:50 ` [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls Steven Rostedt
2012-07-12 12:39 ` Masami Hiramatsu
2012-07-12 15:53 ` Steven Rostedt
2012-07-13 18:47 ` Steven Rostedt
2012-07-17 2:08 ` Masami Hiramatsu
2012-07-17 3:05 ` Steven Rostedt
2012-07-17 3:13 ` Masami Hiramatsu
2012-07-18 15:59 ` Steven Rostedt
2012-07-19 2:20 ` Masami Hiramatsu
2012-07-19 12:52 ` Steven Rostedt
2012-07-19 12:58 ` Steven Rostedt
2012-07-19 22:53 ` H. Peter Anvin
2012-07-19 23:04 ` Steven Rostedt
2012-07-19 23:07 ` H. Peter Anvin
2012-07-20 1:27 ` Steven Rostedt
2012-07-19 18:24 ` Steven Rostedt
2012-08-21 15:03 ` [tip:perf/core] ftrace/x86_32: Simplify parameter setup for ftrace_regs_caller tip-bot for Uros Bizjak
2012-07-11 19:50 ` Steven Rostedt [this message]
2012-08-21 15:04 ` [tip:perf/core] ftrace/x86: Remove function_trace_stop check from graph caller tip-bot for Steven Rostedt
2012-07-11 19:50 ` [RFC][PATCH 4/4 v4] ftrace/x86_64: Add recursion protection inside mcount caller Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711195745.588538769@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox