From: Will Deacon <will.deacon@arm.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>,
"mporter@ti.com" <mporter@ti.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Russ.Dill@ti.com" <Russ.Dill@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] [ARM] Unconditional call to smp_cross_call on UP crashes (take #2)
Date: Mon, 16 Jul 2012 12:22:22 +0100 [thread overview]
Message-ID: <20120716112222.GF26723@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <20120713075937.GC10602@S2100-06.ap.freescale.net>
On Fri, Jul 13, 2012 at 08:59:39AM +0100, Shawn Guo wrote:
> > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> > index 8f46446..7babc3f 100644
> > --- a/arch/arm/kernel/smp.c
> > +++ b/arch/arm/kernel/smp.c
> > @@ -590,7 +590,8 @@ void smp_send_stop(void)
> >
> > cpumask_copy(&mask, cpu_online_mask);
> > cpumask_clear_cpu(smp_processor_id(), &mask);
> > - smp_cross_call(&mask, IPI_CPU_STOP);
> > + if (!cpumask_empty(&mask))
> > + smp_cross_call(&mask, IPI_CPU_STOP);
I wonder whether we shouldn't have a default smp_cross_call implementation
with BUG_ON(!cpumask_empty(&mask)). It's marginally nicer than an explicit NULL
deference and it would also fix your problem.
Will
prev parent reply other threads:[~2012-07-16 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 19:58 Pantelis Antoniou
2012-05-25 6:44 ` Shawn Guo
2012-07-13 7:59 ` Shawn Guo
2012-07-16 11:22 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716112222.GF26723@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Russ.Dill@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mporter@ti.com \
--cc=panto@antoniou-consulting.com \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®