From: Guenter Roeck <linux@roeck-us.net>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (applesmc) Allow negative temperature values
Date: Mon, 16 Jul 2012 18:10:51 -0700 [thread overview]
Message-ID: <20120717011051.GA22234@roeck-us.net> (raw)
In-Reply-To: <1342423091-330-1-git-send-email-rydberg@euromail.se>
On Mon, Jul 16, 2012 at 09:18:10AM +0200, Henrik Rydberg wrote:
> There are many userland reports of sensors with unreasonably small and
> large temperatures. There seem to be several reasons for this:
>
> Firstly, the major sensor type (sp78) is actually a signed number.
> This explains why some sensors show very small or large values - they
> are in fact all small, but of different sign.
>
> Secondly, the other sensor type (1-hex) is not properly understood; it
> may be that it is not a temperature after all.
>
> Thirdly, some sensors are differential in nature, showing changes over
> time rather than absolute numbers. This explains why those values are
> small and of varying sign.
>
> This patch interprets the sp78 type as signed short, but keeps the
> original scaling. For other types, -EINVAL is returned, since the
> nature of those sensors is unknown.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
Applied to -next.
Thanks,
Guenter
prev parent reply other threads:[~2012-07-17 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 7:18 Henrik Rydberg
2012-07-16 7:18 ` [PATCH 2/2] hwmon: (applesmc) Ignore some temperature registers Henrik Rydberg
2012-07-17 1:11 ` [lm-sensors] " Guenter Roeck
2012-07-17 1:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717011051.GA22234@roeck-us.net \
--to=linux@roeck-us.net \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®