From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: dedekind1@gmail.com
Cc: Andrew Victor <linux@maxim.org.za>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Richard Weinberger <richard@nod.at>,
Richard Genoud <richard.genoud@gmail.com>
Subject: Re: [PATCH 1/5] ubi: introduce ubi->bad_peb_limit
Date: Thu, 19 Jul 2012 09:16:00 +0300 [thread overview]
Message-ID: <20120719091600.7d55dadb@pixies.home.jungo.com> (raw)
In-Reply-To: <1342608053.7530.11.camel@brekeke>
On Wed, 18 Jul 2012 13:40:53 +0300 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> I've also amended the Kconfig text a tiny bit and dropped the defconfig
> changes - let's have them separately as a single patch at the end of the
> series.
Wouldn't having the defconfig change as the last patch break things for
those defconfigs that had explicitly set CONFIG_MTD_UBI_BEB_RESERVE
other than the default?
Meaning, if the one-before-last would be "kill CONFIG_MTD_UBI_BEB_RESERVE",
then those defconfigs that had _explicitly_ set a BEB_RESERVE value,
which do not YET set a BEB_LIMIT value, will have their BEB_LIMIT as
the default - but they actually meant a specific value other than the
default.
This is why I tried to:
- set the CONFIG_MTD_UBI_BEB_LIMIT in defconfigs as part of the commit
which introduces this config (copy same value as their RESERVE config)
- kill all CONFIG_MTD_UBI_BEB_RESERVE references from defconfigs as part
of the commit which kills it
Regards,
Shmulik
next prev parent reply other threads:[~2012-07-19 6:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 8:05 [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation Shmulik Ladkani
2012-07-04 8:06 ` [PATCH 1/5] ubi: introduce ubi->bad_peb_limit Shmulik Ladkani
2012-07-18 7:09 ` Artem Bityutskiy
2012-07-18 10:40 ` Artem Bityutskiy
2012-07-19 6:16 ` Shmulik Ladkani [this message]
2012-07-30 13:00 ` Artem Bityutskiy
2012-07-04 8:06 ` [PATCH 2/5] ubi: Limit amount of reserved eraseblocks for bad PEB handling Shmulik Ladkani
2012-07-09 10:15 ` Richard Genoud
2012-07-09 11:02 ` Shmulik Ladkani
2012-07-18 10:28 ` Artem Bityutskiy
2012-07-18 11:01 ` Artem Bityutskiy
2012-07-18 19:55 ` Shmulik Ladkani
2012-07-19 3:35 ` Artem Bityutskiy
2012-07-18 11:40 ` Artem Bityutskiy
2012-07-04 8:06 ` [PATCH 3/5] ubi: kill CONFIG_MTD_UBI_BEB_RESERVE Shmulik Ladkani
2012-07-04 8:06 ` [PATCH 4/5] ubi: trivial: fix comment of ubi_calculate_reserved() Shmulik Ladkani
2012-07-18 10:38 ` Artem Bityutskiy
2012-07-04 8:06 ` [PATCH 5/5] ubi: harmonize the update of ubi->beb_rsvd_pebs Shmulik Ladkani
2012-07-18 11:32 ` Artem Bityutskiy
2012-07-04 8:35 ` [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation Richard Weinberger
2012-07-04 11:33 ` Shmulik Ladkani
2012-07-06 15:27 ` Richard Genoud
2012-07-07 6:14 ` Shmulik Ladkani
2012-07-07 8:32 ` Richard Genoud
2012-07-09 6:58 ` Richard Genoud
2012-07-16 15:33 ` Artem Bityutskiy
2012-07-17 7:23 ` Shmulik Ladkani
2012-07-18 6:54 ` Artem Bityutskiy
2012-07-30 13:56 ` Artem Bityutskiy
2012-07-31 8:19 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719091600.7d55dadb@pixies.home.jungo.com \
--to=shmulik.ladkani@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=richard.genoud@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®