mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: jan.bannister@gmail.com
Cc: schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: acct.c:  spaces required around that '<'
Date: Thu, 19 Jul 2012 23:55:50 +0100	[thread overview]
Message-ID: <20120719225550.GX31729@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1342732227-13972-1-git-send-email-jan.bannister@gmail.com>

On Thu, Jul 19, 2012 at 10:10:27PM +0100, jan.bannister@gmail.com wrote:
> From: Jan Bannister <jan.bannister@gmail.com>
> 
> Fixed a coding style issue

NAK, because I'm sick and tired of the pompous commit messages.  I'm fine
with adding those spaces.  However, I _do_ have a lot against the commit
messages like that.  "Required"?  By whom?  Holy checkpatch.pl?  "Coding
style issue" - completely uninformative; there all kinds of those.

FWIW, my prefernce would be something along the lines of "whitespace
tidy-up in <function or file name>".  At least that says what happens
in commit and where is it happening...

  reply	other threads:[~2012-07-19 22:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 21:10 jan.bannister
2012-07-19 22:55 ` Al Viro [this message]
2012-07-19 21:30 jan.bannister

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120719225550.GX31729@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=jan.bannister@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome