From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229Ab2GTIym (ORCPT ); Fri, 20 Jul 2012 04:54:42 -0400 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:40895 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab2GTIyj (ORCPT ); Fri, 20 Jul 2012 04:54:39 -0400 Date: Fri, 20 Jul 2012 10:54:36 +0200 From: Borislav Petkov To: Alex Shi Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, tj@kernel.org, akpm@linux-foundation.org, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, bp@amd64.org, penguin-kernel@I-love.SAKURA.ne.jp Subject: Re: [PATCH] x86/tlb: fix allnoconfig building warning Message-ID: <20120720085436.GC28767@aftab.osrc.amd.com> References: <1342747103-19765-1-git-send-email-alex.shi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342747103-19765-1-git-send-email-alex.shi@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 20, 2012 at 09:18:23AM +0800, Alex Shi wrote: > The incompatible parameter of flush_tlb_mm_range cause build warning. > Fix it by correct parameter. > > Reported-by: Tetsuo Handa > Signed-off-by: Alex Shi Thanks for this. Btw, the patch Subject should say: "[PATCH] x86, tlb: Fix flush_tlb_mm_range signature" or "[PATCH] x86, tlb: Fix non-SMP build warning" or similar. Having "allnoconfig" in the name is a bit misleading as it is only one of the reasons why we build a !CONFIG_SMP kernel - this can happen with a randbuild too. And the hunk below touches the "#ifndef CONFIG_SMP" part of tlbflush.h... So, long story short, hpa, can pls you correct this when applying? > --- > arch/x86/include/asm/tlbflush.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h > index 621b959..4fc8faf 100644 > --- a/arch/x86/include/asm/tlbflush.h > +++ b/arch/x86/include/asm/tlbflush.h > @@ -105,10 +105,10 @@ static inline void flush_tlb_range(struct vm_area_struct *vma, > __flush_tlb(); > } > > -static inline void flush_tlb_mm_range(struct vm_area_struct *vma, > +static inline void flush_tlb_mm_range(struct mm_struct *mm, > unsigned long start, unsigned long end, unsigned long vmflag) > { > - if (vma->vm_mm == current->active_mm) > + if (mm == current->active_mm) > __flush_tlb(); > } Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551