From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446Ab2GTNoP (ORCPT ); Fri, 20 Jul 2012 09:44:15 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:18980 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063Ab2GTNoO (ORCPT ); Fri, 20 Jul 2012 09:44:14 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 20 Jul 2012 06:39:38 -0700 Date: Fri, 20 Jul 2012 16:43:49 +0300 From: Peter De Schrijver To: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] clk: fix return value check in clk_get Message-ID: <20120720134349.GC9437@tbergstrom-lnx.Nvidia.com> References: <1342791397-11732-1-git-send-email-pdeschrijver@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1342791397-11732-1-git-send-email-pdeschrijver@nvidia.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 20, 2012 at 03:36:37PM +0200, Peter De Schrijver wrote: > of_clk_get_by_name returns an ERR_PTR on failure. Hence we should use IS_ERR() > and not just check for a non NULL value. > > Signed-off-by: Peter De Schrijver > --- > drivers/clk/clkdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c > index 8f87b0f..d423c9b 100644 > --- a/drivers/clk/clkdev.c > +++ b/drivers/clk/clkdev.c > @@ -157,7 +157,7 @@ struct clk *clk_get(struct device *dev, const char *con_id) > > if (dev) { > clk = of_clk_get_by_name(dev->of_node, con_id); > - if (clk && __clk_get(clk)) > + if (!IS_ERR(clk) && __clk_get(clk)) > return clk; > } http://www.spinics.net/lists/arm-kernel/msg184794.html introduces this behaviour of of_clk_get_by_name() Cheers, Peter.