From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH 02/12] usb: fix sillies in the metro USB driver
Date: Mon, 23 Jul 2012 17:32:01 +0100 [thread overview]
Message-ID: <20120723173201.5724b9d0@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4FE78B62.4090106@suse.cz>
On Sun, 24 Jun 2012 23:49:22 +0200
Jiri Slaby <jslaby@suse.cz> wrote:
> On 06/22/2012 05:38 PM, Alan Cox wrote:
> > Bits noticed doing the termios conversion
> >
> > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > ---
> >
> > drivers/usb/serial/metro-usb.c | 8 +-------
> > 1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/drivers/usb/serial/metro-usb.c b/drivers/usb/serial/metro-usb.c
> > index 81423f7..bad5f0c 100644
> > --- a/drivers/usb/serial/metro-usb.c
> > +++ b/drivers/usb/serial/metro-usb.c
> > @@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb)
> ...
> > if (tty && urb->actual_length) {
> > /* Loop through the data copying each byte to the tty layer. */
> > tty_insert_flip_string(tty, data, urb->actual_length);
> >
> > /* Force the data to the tty layer. */
> > tty_flip_buffer_push(tty);
> > + tty_kref_put(tty);
> > }
> > - tty_kref_put(tty);
>
> This doesn't seem right. (Depends on whether tty is non-null iff
> urb->actual_length is non-zero.)
Doh fixed.. queued
next prev parent reply other threads:[~2012-07-23 16:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 15:36 [PATCH 01/12] f81232: correct stubbed termios handler Alan Cox
2012-06-22 15:38 ` [PATCH 02/12] usb: fix sillies in the metro USB driver Alan Cox
2012-06-24 21:49 ` Jiri Slaby
2012-07-23 16:32 ` Alan Cox [this message]
2012-06-22 15:40 ` [PATCH 03/12] tty: note race we need to fix Alan Cox
2012-06-22 15:42 ` [PATCH 04/12] gpio-sch: Fix resource leak Alan Cox
2012-06-27 2:25 ` Greg KH
2012-06-22 15:43 ` [PATCH 05/12] kobil_sct: Fix some bogus tty handling Alan Cox
2012-06-27 2:24 ` Greg KH
2012-06-22 15:43 ` [PATCH 06/12] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-06-27 2:30 ` Greg KH
2012-06-22 15:44 ` [PATCH 07/12] 8250: propogate the bugs field Alan Cox
2012-06-22 15:44 ` [PATCH 08/12] 8250: add support for ASIX devices with a FIFO bug Alan Cox
2012-06-22 15:44 ` [PATCH 09/12] commit 22126843cb3c2a782c2d52614486115f3e9db478 Alan Cox
2012-06-22 15:36 ` Greg KH
2012-06-22 17:04 ` Alan Cox
2012-08-01 0:51 ` Yinghai Lu
2012-06-22 15:46 ` [PATCH 10/12] tty: tidy up the RESET_TERMIOS case Alan Cox
2012-06-22 15:46 ` [PATCH 11/12] vt: fix the keyboard/led locking Alan Cox
2012-06-22 15:47 ` [PATCH 12/12] tty: move the handling of the tty release logic Alan Cox
2012-08-01 0:47 ` Yinghai Lu
2012-06-27 2:22 ` [PATCH 01/12] f81232: correct stubbed termios handler Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723173201.5724b9d0@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®