mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet@google.com>
To: Daniel Wisehart <daniel.wisehart@eladian.com>
Cc: linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [Bcache v14 PATCH] fix compiler error
Date: Mon, 23 Jul 2012 14:12:12 -0700	[thread overview]
Message-ID: <20120723211212.GA29052@google.com> (raw)
In-Reply-To: <0d1ae163-7cde-4a78-852a-04fba827249f@mail.eladian.com>

On Thu, Jul 19, 2012 at 04:53:26PM -0400, Daniel Wisehart wrote:
> Hello Kent, 
> 
> This patch keeps gcc 4.7.0 happy.  The static function dump_bset() could be moved, but that would have made a bigger patch.  :-)

Thanks! dump_bset() does need to be moved so it's available if DEBUG or
EDEBUG are on, but thanks for pointing it out :)

> 
> Thanks,
> Daniel
> 
> 
> 
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index 3c9c24d..4dc0ba5 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -83,6 +83,8 @@ struct keyprint_hack bch_pbtree(const struct btree *b)
>  
>  #ifdef CONFIG_BCACHE_DEBUG
>  
> +static void dump_bset(struct btree *b, struct bset *i);
> +
>  void bch_btree_verify(struct btree *b, struct bset *new)
>  {
>         struct btree *v = b->c->verify_data;
> 
> 
> This communication is restricted - please see http://www.eladian.com for further information.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2012-07-23 21:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1abe2159-2201-46c4-9c60-afc4f358ff6a@mail.eladian.com>
2012-07-19 20:53 ` Daniel Wisehart
2012-07-23 21:12   ` Kent Overstreet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120723211212.GA29052@google.com \
    --to=koverstreet@google.com \
    --cc=daniel.wisehart@eladian.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome