Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample

[Jiri Olsa <jolsa@redhat.com>]

On Wed, Jul 25, 2012 at 06:36:28PM +0200, Frederic Weisbecker wrote:
> On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote:
> > Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger
> > the dump of the user level stack on sample. The size of the
> > dump is specified by sample_stack_user value.
> > 
> > Being able to dump parts of the user stack, starting from the
> > stack pointer, will be useful to make a post mortem dwarf CFI
> > based stack unwinding.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
please use:

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Original-patch-by: Frederic Weisbecker <fweisbec@gmail.com>

> 
> If you keep the SOB of the author then you need to preserve its
> authorship (git am --author= / git commit --amend --author=).
> Unless you changed the patch significantly enough that you
> simply credit with something like "Original-patch-by" and you become the
> author. This is left to personal appreciation, I won't mind
> in any case.
> 
> But there is no middle ground :)
> You also need to keep the SOB chain in order. The above SOB chain
> suggests I'm carrying a patch from you.
> 
> Just saying that so that you make the maintainers job easier ;)

ok, I misunderstood this one when we discussed this, sorry

The userspace part have some bad ones as well.. I talked to Arnaldo
how to deal with them :)

thanks,
jirka