From: Michal Marek <mmarek@suse.cz>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: kbuild: Document oldnoconfig to what it really does
Date: Thu, 26 Jul 2012 14:30:17 +0200 [thread overview]
Message-ID: <20120726123017.GD25512@sepie.suse.cz> (raw)
In-Reply-To: <1339802699.25903.47.camel@gandalf.stny.rr.com>
On Fri, Jun 15, 2012 at 07:24:59PM -0400, Steven Rostedt wrote:
> The make target 'oldnoconfig' is a misnomer. It doesn't set new symbols
> to 'n', but instead sets it to their default values.
>
> Unfortunately, assuming that it actually did this, broke ktest in some
> of its tests. For example, the tests to create a minimum config and even
> a config bisect, depends on removing various configs and using
> oldnoconfig to get rid of other configs that may have depended on it.
>
> But because some configs that it was trying to disable, were in fact
> default enabled, this caused those configs to re-enable and corrupt the
> test.
>
> I thought about fixing oldnoconfig, but I'm afraid that people are
> already dependent on its current behavior. Instead, I'm just updating
> the documentation to state that it sets the new symbols to their default
> values and not to 'n'.
>
> Ideally, this would be called, 'olddefconfig' and we have an
> 'oldnoconfig' that actually disables the new symbols. But it's useless
> for me now. If it changed, ktest would need to be consistent between
> each version, and that would be to difficult to detect. I'll handle this
> issue with ktest with other means.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Applied to kbuild.git#kconfig, thanks.
Michal
prev parent reply other threads:[~2012-07-26 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 23:24 Steven Rostedt
2012-07-26 12:30 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726123017.GD25512@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®