From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Fix argument to _notifier_call_chain call
Date: Sun, 29 Jul 2012 21:39:36 +0100 [thread overview]
Message-ID: <20120729203935.GG4384@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343548396.9481.1.camel@phoenix>
On Sun, Jul 29, 2012 at 03:53:16PM +0800, Axel Lin wrote:
> Pass the address of best_val rather than the value of best_val for the third
> argument to _notifier_call_chain().
>
> This fixes below build warning:
> CC drivers/regulator/core.o
> drivers/regulator/core.c: In function '_regulator_do_set_voltage':
> drivers/regulator/core.c:2183:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
No, this isn't a good idea - you're fixing a warning by changing the
semantics to be something obscure and not terribly helpful. Just add a
cast if your compiler is getting upset.
prev parent reply other threads:[~2012-07-29 20:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 7:53 Axel Lin
2012-07-29 20:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729203935.GG4384@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome