From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754318Ab2G3PjN (ORCPT ); Mon, 30 Jul 2012 11:39:13 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:53607 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922Ab2G3PjM (ORCPT ); Mon, 30 Jul 2012 11:39:12 -0400 Date: Mon, 30 Jul 2012 08:39:07 -0700 From: Greg Kroah-Hartman To: Mel Gorman Cc: Herton Ronaldo Krzesinski , linux-kernel@vger.kernel.org, stable@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Miao Xie , David Rientjes , Peter Zijlstra , Christoph Lameter Subject: Re: [ 39/40] cpuset: mm: reduce large amounts of memory barrier related damage v3 Message-ID: <20120730153907.GB28633@kroah.com> References: <20120726211424.GA7709@kroah.com> <20120726211411.164006056@linuxfoundation.org> <20120726211414.752069185@linuxfoundation.org> <20120727150823.GD3033@herton-Z68MA-D2H-B3> <20120727152347.GG612@suse.de> <20120727190116.GA29646@kroah.com> <20120728050230.GA9155@herton-Z68MA-D2H-B3> <20120728102609.GH612@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120728102609.GH612@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 28, 2012 at 11:26:09AM +0100, Mel Gorman wrote: > On Sat, Jul 28, 2012 at 02:02:31AM -0300, Herton Ronaldo Krzesinski wrote: > > > Thanks, I've merged this with the "original" in the tree, so all should > > > be good now. > > > > Thanks. I saw what seems another issue now on the patch too, sorry for > > not noticing earlier: this backport is lacking the > > write_seqcount_{begin,end} on set_mems_allowed for the case with > > CONFIG_CPUSETS, like in the original patch: > > > > Not my finest moment :( > > Thanks > > ---8<--- > cpuset: mm: reduce large amounts of memory barrier related damage v3 fix > > Missing hunk from backport. > > Reported-by: Herton Ronaldo Krzesinski > Signed-off-by: Mel Gorman > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > index 8f15695..7a7e5fd 100644 > --- a/include/linux/cpuset.h > +++ b/include/linux/cpuset.h > @@ -113,7 +113,9 @@ static inline bool put_mems_allowed(unsigned int seq) > static inline void set_mems_allowed(nodemask_t nodemask) > { > task_lock(current); > + write_seqcount_begin(¤t->mems_allowed_seq); > current->mems_allowed = nodemask; > + write_seqcount_end(¤t->mems_allowed_seq); > task_unlock(current); > } Added to the patch, thanks. I think with this change, and the others requested, I'll do a -rc2 just so that people can test it all again. greg k-h