mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Steven Rostedt <srostedt@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: __update_max_tr: rcu_read_lock() used illegally while idle!
Date: Tue, 31 Jul 2012 08:18:09 -0700	[thread overview]
Message-ID: <20120731151808.GF2422@linux.vnet.ibm.com> (raw)
In-Reply-To: <1343746583.27983.55.camel@gandalf.stny.rr.com>

On Tue, Jul 31, 2012 at 10:56:23AM -0400, Steven Rostedt wrote:
> On Tue, 2012-07-31 at 10:51 -0400, Steven Rostedt wrote:
> 
> > > OK, I will bite.  How about using something like RCU_NONIDLE(), either
> > > directly or open-coded, to make it a legal call site?
> > 
> > OK, then something like:
> > 
> > 	RCU_NONIDLE(max_data = task_uid(tsk));
> > 
> > would work when called normally or with idle?
> > 
> 
> The comment above RCU_NONIDLE() says:
> 
> 	This macro may be used from process-level code only.
> 
> Although I'm not sure what a 'level' is. Do you mean process-context? If
> so, then this will not work because it can be called from non process
> level code (return from interrupt), or any interrupt that enables
> interrupts.

Yep, process context.  It seems that I was naively expecting the
calls in interrupt context to be covered by rcu_irq_enter() and
rcu_irq_exit().  I take it that these calls are happening outside of
the rcu_irq_enter()-protected region?

							Thanx, Paul


  reply	other threads:[~2012-07-31 15:19 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24  9:03 Fengguang Wu
2012-07-24  9:07 ` Testing tracer wakeup_rt: .. no entries found ..FAILED! Fengguang Wu
2012-07-25  1:31   ` Testing tracer wakeup: " Fengguang Wu
2012-07-30 15:45   ` Testing tracer wakeup_rt: " Steven Rostedt
2012-07-31 12:17     ` Fengguang Wu
2012-07-31 12:37       ` Avi Kivity
2012-07-31 12:43         ` Steven Rostedt
2012-07-31 12:50           ` Avi Kivity
2012-07-31 13:13             ` Steven Rostedt
2012-07-31 23:43               ` Fengguang Wu
2012-07-31 23:51                 ` Steven Rostedt
2012-07-31 23:57                   ` Paul E. McKenney
2012-08-01  0:09                     ` Steven Rostedt
2012-08-01  0:18                       ` Paul E. McKenney
2012-08-01  0:43                         ` pci_get_subsys: GFP_KERNEL allocations with IRQs disabled Fengguang Wu
2012-08-22  2:50                           ` Fengguang Wu
2012-08-22  7:49                             ` Feng Tang
2012-08-22 13:02                               ` Fengguang Wu
2012-08-22 18:02                               ` Bjorn Helgaas
2012-08-23  5:45                                 ` Feng Tang
2012-08-23  7:45                                 ` [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class() Feng Tang
2012-09-08  1:00                                   ` Yinghai Lu
2012-09-08  1:32                                     ` Yinghai Lu
2012-09-08  1:59                                       ` Greg Kroah-Hartman
2012-09-08 13:42                                       ` Fengguang Wu
2012-09-08 15:30                                         ` Yinghai Lu
2012-09-08 15:34                                         ` Feng Tang
2012-09-08 18:40                                           ` Yinghai Lu
2012-09-08 21:06                                             ` Bjorn Helgaas
2012-08-23  7:45                                 ` [PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check Feng Tang
2012-07-31 23:57                   ` Testing tracer wakeup_rt: .. no entries found ..FAILED! Fengguang Wu
2012-08-07 13:29                     ` Steven Rostedt
2012-08-07 13:32                       ` Fengguang Wu
2012-08-21 15:16     ` [tip:perf/core] tracing: Fix wakeup_rt self test on virtual machines tip-bot for Steven Rostedt
2012-07-30 15:39 ` __update_max_tr: rcu_read_lock() used illegally while idle! Steven Rostedt
2012-07-31 12:05   ` Fengguang Wu
2012-07-31 12:10     ` Fengguang Wu
2012-07-31 13:44       ` Steven Rostedt
2012-07-31 14:41         ` Paul E. McKenney
2012-07-31 13:33     ` Steven Rostedt
2012-07-31 14:44       ` Paul E. McKenney
2012-07-31 14:51         ` Steven Rostedt
2012-07-31 14:56           ` Steven Rostedt
2012-07-31 15:18             ` Paul E. McKenney [this message]
2012-07-31 15:45               ` Steven Rostedt
2012-07-31 17:17                 ` Paul E. McKenney
2012-07-31 17:24                   ` Steven Rostedt
2012-07-31 17:44                     ` Paul E. McKenney
2012-07-31 18:06                       ` Steven Rostedt
2012-07-31 18:21                         ` Paul E. McKenney
2012-07-31 15:00           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731151808.GF2422@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome