From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755209Ab2HAOih (ORCPT ); Wed, 1 Aug 2012 10:38:37 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:53129 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004Ab2HAOif (ORCPT ); Wed, 1 Aug 2012 10:38:35 -0400 From: Arnd Bergmann To: Vinayak Holikatti Subject: Re: [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code Date: Wed, 1 Aug 2012 14:38:28 +0000 User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; ) Cc: James.Bottomley@hansenpartnership.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, patches@linaro.org, linux-samsung-soc@vger.kernel.org, arnd@linaro.org, girish.shivananjappa@linaro.org, saugata.das@linaro.org, vishak.g@samsung.com, venkat@linaro.org, k.rajesh@samsung.com, dsaxena@linaro.org, ilho215.lee@samsung.com, nala.la@samsung.com, sreekumar.c@samsung.com, Santosh Yaraganavi References: <1343292170-2599-1-git-send-email-vinholikatti@gmail.com> <1343292170-2599-2-git-send-email-vinholikatti@gmail.com> In-Reply-To: <1343292170-2599-2-git-send-email-vinholikatti@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201208011438.28719.arnd@arndb.de> X-Provags-ID: V02:K0:7yE5BydGIvy08cvaLj7qQ6nhLdupFOriUg2IZqvM/7U hIRMa8ME3TkJnK0JREm/ZchJLKOYCRO4XeoHXH1o31VmI9NgF3 S/hRzhlfHIHpwb35TEDO7aqp+QxHyYcn4mnW/LbFrC1tpKki0t ReRbMR693+A4z5Y8JPWDMv5apOV73NcOlk/RJqywxk0WQk7rjX 1YCc8el4/WzoCSmnvVOQ0eaZBnTEE6meDKrpbCNo1eDxLobIDj 1oFAxa4BxOpdbXY2QsDK/wahbn6nNhG5OpFZgjYlzsOAFAHsW1 kXMU1bXAuiU81Ro8nO+62bQveav03chH5i5NtZREyYu3s6rAt7 v6LPcfWWGtM0wEVezyhk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 26 July 2012, Vinayak Holikatti wrote: > -static void ufshcd_remove(struct pci_dev *pdev) > +void ufshcd_remove(struct ufs_hba *hba) > { > - struct ufs_hba *hba = pci_get_drvdata(pdev); > - > /* disable interrupts */ > ufshcd_int_config(hba, UFSHCD_INT_DISABLE); > - free_irq(pdev->irq, hba); > > ufshcd_hba_stop(hba); > ufshcd_hba_free(hba); > > scsi_remove_host(hba->host); > scsi_host_put(hba->host); > +} > +EXPORT_SYMBOL(ufshcd_remove); For driver internal symbols, you should always use "EXPORT_SYMBOL_GPL" here. Arnd