From: Anthony Olech (Opensource) <anthony.olech.opensource@diasemi.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Anthony Olech <anthony.olech@diasemi.com>
Cc: Dajun Chen <david.chen@diasemi.com>
Subject: [PATCH] regmap-irq: allow auto-allocated IRQs to be mapped
Date: Wed, 1 Aug 2012 19:05:15 +0100 [thread overview]
Message-ID: <201208011832.q71IWEHu013706@latitude.olech.com> (raw)
if the irq_base is set to -1 when calling regmap_add_irq_chip()
then allow the IRQ to be mapped even if the allocated irq_base
is actually zero.
This restores the behaviour seen in v3.4, and I assume that the
tidy-ups just made in v3.5 INADVERTENTLY introduce this change
in behaviour.
Signed-off-by: Anthony Olech (Opensource) <anthony.olech.opensource@diasemi.com>
---
drivers/base/regmap/regmap-irq.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index a897346..2441785 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -238,6 +238,7 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
struct regmap_irq_chip_data *d;
int i;
int ret = -ENOMEM;
+ int orig_irq_base = irq_base;
for (i = 0; i < chip->num_irqs; i++) {
if (chip->irqs[i].reg_offset % map->reg_stride)
@@ -313,7 +314,7 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
}
}
- if (irq_base)
+ if (irq_base || orig_irq_base)
d->domain = irq_domain_add_legacy(map->dev->of_node,
chip->num_irqs, irq_base, 0,
®map_domain_ops, d);
--
end-of-patch for regmap-irq-bug-fix
next reply other threads:[~2012-08-01 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:05 Anthony Olech [this message]
[not found] <201208020805.q72858Yj003147@latitude.olech.com>
2012-08-04 10:54 ` Mark Brown
2012-08-05 19:57 ` Opensource [Anthony Olech]
2012-08-06 12:20 ` Mark Brown
2012-08-07 11:18 ` Opensource [Anthony Olech]
2012-08-07 14:03 ` Mark Brown
2012-08-07 14:37 ` Opensource [Anthony Olech]
2012-08-07 17:02 ` Mark Brown
2012-08-08 8:30 ` Opensource [Anthony Olech]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208011832.q71IWEHu013706@latitude.olech.com \
--to=anthony.olech.opensource@diasemi.com \
--cc=anthony.olech@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®