From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026Ab2HBMmF (ORCPT ); Thu, 2 Aug 2012 08:42:05 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:38803 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753576Ab2HBMmD (ORCPT ); Thu, 2 Aug 2012 08:42:03 -0400 Date: Thu, 2 Aug 2012 14:41:57 +0200 From: Heiko Carstens To: Jiri Kosina Cc: Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] [S390] do not clobber personality flags in sys_32_personality() Message-ID: <20120802124157.GA5742@osiris.boeblingen.de.ibm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) x-cbid: 12080212-0542-0000-0000-000002A23FFE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 02, 2012 at 09:11:23AM +0200, Jiri Kosina wrote: > There are multiple errors in how sys_32_personality() handles personality > flags stored in top three bytes. > > - directly comparing current->personality against PER_LINUX32 doesn't work > in cases when any of the personality flags stored in the top three bytes > are used. > - directly forcefully setting personality to PER_LINUX32 or PER_LINUX > discards any flags stored in the top three bytes > > Fix the first one by properly using personality() macro to compare only > PER_MASK bytes. > Fix the second one by setting only the bits that should be set, instead of > overwriting the whole value. Applied. Thanks!