From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: linux-kbuild@vger.kernel.org
Cc: Benjamin Poirier <bpoirier@suse.de>,
Borislav Petkov <bp@alien8.de>,
Borislav Petkov <borislav.petkov@amd.com>,
Michal Marek <mmarek@suse.cz>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Arnaud Lacombe <lacombar@gmail.com>,
linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH 0/6] menuconfig: jump to search results
Date: Thu, 2 Aug 2012 23:38:40 +0200 [thread overview]
Message-ID: <201208022338.41040.yann.morin.1998@free.fr> (raw)
In-Reply-To: <20120802141847.GB21766@d2.synalogic.ca>
All,
On Thursday 02 August 2012 16:18:47 Benjamin Poirier wrote:
> On 2012/08/02 15:32, Borislav Petkov wrote:
> > On Tue, Jul 31, 2012 at 09:17:51AM -0400, Benjamin Poirier wrote:
> > > > * when searching for "DELAY" for example, I get results without numbers
> > > > to which I can't jump to:
> > > >
> > > > ...
> > > > │ Symbol: DEFAULT_IO_DELAY_TYPE [=0]
> > > > │ Type : integer
> > > > │
> > > > │
> > > > │ Symbol: IO_DELAY_TYPE_0X80 [=0]
> > > > │ Type : integer
> > > > ...
> > > >
> > > > maybe because they don't have "---help---" section?
> > >
> > > Because they don't have a prompt - they don't appear in any menu at all.
> > > In that case there's nowhere to jump to. That's why those symbols don't
> > > get a number.
> >
> > Right, so how about you don't show them at all then?
>
> It's a search for CONFIG_ symbols not "menus". Even though the user
> doesn't have direct control over some symbols, it's still useful to know
> they exist and (possibly) what enables them. For example, searching for
> LOCKDEP tells me I can enable DEBUG_LOCK_ALLOC to get it.
Agreed.
Consider this (very simple) situation :
config A
bool "A"
select B
config B
bool
config C
bool "C"
depends on B
Returning the symbol B in the search results allows to:
- see its dependencies -> to see why it is thus set
- see in what file it is defined -> to change the deps and/or selects
So, yes, returning prompt-less symbols as search results is important.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2012-08-02 21:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 19:22 Benjamin Poirier
2012-07-30 19:22 ` [PATCH 1/6] menuconfig: Remove superfluous conditionnal Benjamin Poirier
2012-07-30 19:22 ` [PATCH 2/6] menuconfig: Extend dialog_textbox so that it can exit on arbitrary keypresses Benjamin Poirier
2012-07-30 19:22 ` [PATCH 3/6] menuconfig: Extend dialog_textbox so that it can return to a scrolled position Benjamin Poirier
2012-07-30 19:22 ` [PATCH 4/6] menuconfig: Add jump keys to search results Benjamin Poirier
2012-07-30 19:22 ` [PATCH 5/6] menuconfig: Do not open code textbox scroll up/down Benjamin Poirier
2012-07-30 19:22 ` [PATCH 6/6] menuconfig: Assign jump keys per-page instead of globally Benjamin Poirier
2012-07-30 19:58 ` [PATCH 0/6] menuconfig: jump to search results Borislav Petkov
2012-07-30 20:22 ` Benjamin Poirier
2012-07-31 7:57 ` Borislav Petkov
2012-07-31 13:17 ` Benjamin Poirier
2012-08-02 13:32 ` Borislav Petkov
2012-08-02 14:18 ` Benjamin Poirier
2012-08-02 21:38 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208022338.41040.yann.morin.1998@free.fr \
--to=yann.morin.1998@free.fr \
--cc=borislav.petkov@amd.com \
--cc=bp@alien8.de \
--cc=bpoirier@suse.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mmarek@suse.cz \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®