From: Jean Delvare <khali@linux-fr.org>
To: "Amaury Decrême" <amaury.decreme@gmail.com>
Cc: ben-linux@fluff.org, w.sang@pengutronix.de, rob@landley.net,
jeffrey.t.kirsher@intel.com, akpm@linux-foundation.org,
davem@davemloft.net, gregkh@linuxfoundation.org, joe@perches.com,
ralf@linux-mips.org, dirk.brandewie@gmail.com,
jayachandranc@netlogicmicro.com, linux-i2c@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] I2C: SIS964: Bus driver
Date: Fri, 3 Aug 2012 18:07:12 +0200 [thread overview]
Message-ID: <20120803180712.1e768042@endymion.delvare> (raw)
In-Reply-To: <1344008145-14579-1-git-send-email-amaury.decreme@gmail.com>
Hi Amaury,
On Fri, 3 Aug 2012 17:35:43 +0200, Amaury Decrême wrote:
> This series of patches are a I2C bus driver for the SIS964.
>
>
> The SIS964 is nearly the same as SIS630 for the SMBUS :
> - Most of the SMBus registers (Status, Enable, Control,
> Host Control, etc.) are at the same adresses + 0x60
> - The register count is 21 instead of 20
>
> The SIS964 name is ambiguous as this chip isn't part of the SIS96X
> family and behaves differently.
>
> The datasheets have been used to develop the driver based on the
> exsiting driver for I2C SIS630 .
What is the rationale for not adding support for the new chip to
i2c-sis630 then? That would probably be a lot easier to review.
> Content of the patches:
> - 1/2 The driver itself
> - 2/2 Documentation, Kconfig, Makefile, Maintainers
This split makes little sense. Integration should come with the driver,
otherwise even build-testing is impossible.
--
Jean Delvare
next prev parent reply other threads:[~2012-08-03 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 15:35 Amaury Decrême
2012-08-03 15:35 ` [PATCH v2 1/2] I2C: SIS964: Bus driver - Driver Amaury Decrême
2012-08-03 15:35 ` [PATCH v2 2/2] I2C: SIS964: Bus driver - other files Amaury Decrême
2012-08-03 16:07 ` Jean Delvare [this message]
2012-08-03 16:36 ` [PATCH v2 0/2] I2C: SIS964: Bus driver Amaury Decrême
2012-08-03 17:07 ` Jean Delvare
2012-08-04 0:38 ` Amaury Decrême
2012-08-05 12:04 ` Jean Delvare
2012-08-05 22:03 ` Amaury Decrême
2012-08-05 22:11 ` [PATCH 0/2] I2C: SIS630: Add SIS964 support Amaury Decrême
2012-08-05 22:11 ` [PATCH 1/2] I2C: SIS630: Add SiS964 support Amaury Decrême
2012-08-05 22:11 ` [PATCH 2/2] I2C: SIS630: Cosmetics Amaury Decrême
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120803180712.1e768042@endymion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=amaury.decreme@gmail.com \
--cc=ben-linux@fluff.org \
--cc=davem@davemloft.net \
--cc=dirk.brandewie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jayachandranc@netlogicmicro.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rob@landley.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®