From: Jean Delvare <khali@linux-fr.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/i2c/i2c-smbus.c: convert kzalloc to devm_kzalloc
Date: Sat, 4 Aug 2012 21:43:05 +0200 [thread overview]
Message-ID: <20120804214305.2c18b13a@endymion.delvare> (raw)
In-Reply-To: <1344100248-16238-1-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
On Sat, 4 Aug 2012 19:10:48 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Converting kzalloc to devm_kzalloc simplifies the code and ensures that the
> result, alert, is freed after the irq allocated by the subsequent
> devm_request_irq. This in turn ensures that when an interrupt can be
> triggered, the alert structure is still available.
Good point. I honestly have no idea why this driver's resources are
half managed, it doesn't make much sense...
Patch applied, with a comment clarified, thanks.
--
Jean Delvare
prev parent reply other threads:[~2012-08-04 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 17:10 Julia Lawall
2012-08-04 19:43 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120804214305.2c18b13a@endymion.delvare \
--to=khali@linux-fr.org \
--cc=Julia.Lawall@lip6.fr \
--cc=ben-linux@fluff.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®