mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	Russell King <linux@arm.linux.org.uk>,
	Tony Lindgren <tony@atomide.com>, Jon Medhurst <tixy@yxit.co.uk>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
	Shawn Guo <shawn.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	Dongjin Kim <dongjin.kim@agreeyamobility.net>
Subject: Re: [PATCH] ODROID-X: hkdk4412: Add new hardware based on Exynos4412
Date: Mon, 6 Aug 2012 15:57:03 +0100	[thread overview]
Message-ID: <20120806145702.GB29272@sirena.org.uk> (raw)
In-Reply-To: <1344262254-14648-1-git-send-email-dongjin.kim@agreeyamobility.net>

On Mon, Aug 06, 2012 at 11:10:51PM +0900, Dongjin Kim wrote:

> +static struct regulator_consumer_supply __initdata max77686_buck4_consumer[] = {
> +	REGULATOR_SUPPLY("vdd_g3d", NULL),
> +};

Not that it matters much since new board drivers won't get merged but
all your regulator setup here is problematic.  These look like names
from the board schematic as opposed to mappings of the supplies onto the
consumer devices.

> +static struct regulator_init_data __initdata max77686_buck1_data = {
> +	.constraints = {
> +		.name		= "vdd_mif range",

This would normally just be the name of the supply for display purposes.

  reply	other threads:[~2012-08-06 14:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-06 14:10 Dongjin Kim
2012-08-06 14:57 ` Mark Brown [this message]
2012-08-06 17:37 ` Thomas Abraham
2012-08-06 18:16   ` 회신: " Dongjin Kim
2012-08-06 18:33     ` Olof Johansson
2012-08-07  2:05       ` 회신: " Dongjin Kim
2012-08-07  2:28         ` Olof Johansson
2012-08-07  2:56           ` 회신: " Dongjin Kim
2012-08-07  4:14           ` Thomas Abraham
2012-08-07  4:38             ` Kyungmin Park
2012-08-07 18:49 ` [PATCH v2] " Dongjin Kim
2012-08-08  2:23   ` Kukjin Kim
2012-08-08  2:41     ` 회신: " Dongjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120806145702.GB29272@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=dongjin.kim@agreeyamobility.net \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=shawn.guo@linaro.org \
    --cc=tixy@yxit.co.uk \
    --cc=tobetter@gmail.com \
    --cc=tony@atomide.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®