From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756753Ab2HFQ7u (ORCPT ); Mon, 6 Aug 2012 12:59:50 -0400 Received: from lola.svc-box.de ([82.149.231.63]:52535 "EHLO lola.svc-box.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756718Ab2HFQ7s (ORCPT ); Mon, 6 Aug 2012 12:59:48 -0400 Date: Mon, 6 Aug 2012 18:59:46 +0200 From: Tino Reichardt To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [Jfs-discussion] [PATCH] fs/jfs: TRIM support for JFS Filesystem Message-ID: <20120806165946.GA8815@mcmilk.de> References: <20120726213219.GA28330@mcmilk.de> <20120728110805.GA690@mcmilk.de> <50185916.7010705@oracle.com> <20120801192934.GB19139@mcmilk.de> <20120801200829.GA30608@mcmilk.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120801200829.GA30608@mcmilk.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > * Dave Kleikamp wrote: > > > On 07/28/2012 06:08 AM, Tino Reichardt wrote: > > > > * Tino Reichardt wrote: > > > >> > This patch adds support for the two linux interfaces of the discard/TRIM > > > >> > command for SSD devices and sparse/thinly-provisioned LUNs. > > > > Fixed a problem when setting minlen in jfs_ioc_trim(). > > Oops, setting minlen in jfs_ioc_trim() was again wrong :/ > > I changed this > if (minlen < 0) > minlen = 1; > > to this: > if (minlen <= 0) > minlen = 1; > > This is important, since fstrim() sets it to zero. > > > Fully working patch is located here: > http://www.mcmilk.de/projects/jfs-trim/linux-tree/jfs-trim-2012-08-01_v2.diff > > Signed-off-by: Tino Reichardt The patch is ready, who will submit it into the mainline? -- regards, TR