From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759390Ab2HIAHs (ORCPT ); Wed, 8 Aug 2012 20:07:48 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:47581 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757858Ab2HIAHq (ORCPT ); Wed, 8 Aug 2012 20:07:46 -0400 Date: Wed, 8 Aug 2012 17:07:11 -0700 From: Kent Overstreet To: Tejun Heo Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, agk@redhat.com, neilb@suse.de, drbd-dev@lists.linbit.com, vgoyal@redhat.com, mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net Subject: Re: [PATCH v5 03/12] block: Add bio_reset() Message-ID: <20120809000711.GB7262@moria.home.lan> References: <1344290921-25154-1-git-send-email-koverstreet@google.com> <1344290921-25154-4-git-send-email-koverstreet@google.com> <20120808221129.GB6983@dhcp-172-17-108-109.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120808221129.GB6983@dhcp-172-17-108-109.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 08, 2012 at 03:11:29PM -0700, Tejun Heo wrote: > Hello, > > On Mon, Aug 06, 2012 at 03:08:32PM -0700, Kent Overstreet wrote: > > Reusing bios is something that's been highly frowned upon in the past, > > but driver code keeps doing it anyways. If it's going to happen anyways, > > we should provide a generic method. > > > > This'll help with getting rid of bi_destructor - drivers/block/pktcdvd.c > > was open coding it, by doing a bio_init() and resetting bi_destructor. > > > > v5: Add a define BIO_RESET_BITS, to be very explicit about what parts of > > bio->bi_flags are saved. > > > > Signed-off-by: Kent Overstreet > > Change-Id: I4eb2975bd678d3be811d5423d0620b08020be9ff > > Please drop Change-Id. Die gerrit die. Bah, missed that one. > > +void bio_reset(struct bio *bio) > > +{ > > + unsigned long flags = bio->bi_flags & (~0UL << BIO_RESET_BITS); > > How many flags are we talking about? If there aren't too many, I'd > prefer explicit BIO_FLAGS_PRESERVED or whatever. It mostly isn't actual flags that are preserved - the high bits of the flags are used for indicating what slab the bvec was allocated from, and that's the main thing that has to be preserved. So that's why I went with defining the things that are reset instead of the things that are preserved. I would prefer if bitfields were used for at least BIO_POOL_IDX, but the problem is flags is used as an atomic bit vector for BIO_UPTODATE. But flags isn't treated as an atomic bit vector elsewhere - bio_flagged() doesn't use test_bit(), and flags are set/cleared with atomic bit operations in some places but not in others (probably _most_ of them are technically safe, but... ick). > > Thanks. > > -- > tejun