From: Felipe Balbi <balbi@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Infinite looping in omap2430.c USB driver
Date: Thu, 9 Aug 2012 14:15:51 +0300 [thread overview]
Message-ID: <20120809111549.GT12174@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120707083949.2cf91eeb@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Sat, Jul 07, 2012 at 08:39:49AM +1000, NeilBrown wrote:
>
> Hello `./scripts/get_maintainer.pl -f drivers/usb/musb/omap2430.c`
>
> omap2430_musb_set_vbus in omap2430.c contains:
>
> while (musb_readb(musb->mregs, MUSB_DEVCTL) & 0x80) {
>
> cpu_relax();
>
> if (time_after(jiffies, timeout)) {
> dev_err(musb->controller,
> "configured as A device timeout");
> ret = -EINVAL;
> break;
> }
> }
>
> having set
> unsigned long timeout = jiffies + msecs_to_jiffies(1000);
hehe, that's nasty. Please send a patch converting to a try count and a
udelay_range(), or something.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-09 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 22:39 NeilBrown
2012-07-09 8:32 ` Tony Lindgren
2012-07-30 0:16 ` NeilBrown
2012-08-09 11:15 ` Felipe Balbi [this message]
2012-08-13 2:34 ` NeilBrown
2012-08-13 14:32 ` Felipe Balbi
2012-08-13 21:46 ` NeilBrown
2012-08-14 7:58 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809111549.GT12174@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®