From: Thierry Reding <thierry.reding@avionic-design.de>
To: David Henningsson <david.henningsson@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] ALSA: hda - Deferred probing with request_firmware_nowait()
Date: Thu, 9 Aug 2012 16:04:03 +0200 [thread overview]
Message-ID: <20120809140403.GA10145@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <5023C0FC.2030207@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Thu, Aug 09, 2012 at 03:54:04PM +0200, David Henningsson wrote:
> On 08/09/2012 03:36 PM, Takashi Iwai wrote:
> >+/* callback from request_firmware_nowait() */
> >+static void azx_firmware_cb(const struct firmware *fw, void *context)
> >+{
> >+ struct snd_card *card = context;
> >+ struct azx *chip = card->private_data;
> >+ struct pci_dev *pci = chip->pci;
> >+
> >+ if (!fw) {
> >+ snd_printk(KERN_ERR SFX "Cannot load firmware, aborting\n");
> >+ goto error;
> >+ }
>
> Another thing, aren't you missing a
>
> chip->fw = fw;
>
> here?
Adding that line here fixes the problem for me.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-09 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 6:45 [PATCH] ALSA: hda - Defer probe when loading patch firmware Thierry Reding
2012-08-09 6:57 ` Takashi Iwai
2012-08-09 7:08 ` Thierry Reding
2012-08-09 7:31 ` Takashi Iwai
2012-08-09 7:36 ` Thierry Reding
2012-08-09 7:42 ` Takashi Iwai
2012-08-09 7:50 ` Takashi Iwai
2012-08-09 7:57 ` Thierry Reding
2012-08-09 8:07 ` Thierry Reding
2012-08-09 8:21 ` Takashi Iwai
2012-08-09 9:19 ` Takashi Iwai
2012-08-09 10:34 ` Thierry Reding
2012-08-09 12:32 ` Takashi Iwai
2012-08-09 12:49 ` Thierry Reding
2012-08-09 13:06 ` Takashi Iwai
2012-08-09 13:09 ` [PATCH 0/2] HD-audio firmware loading fixes Takashi Iwai
2012-08-09 13:10 ` [PATCH 1/2] ALSA: hda - Load firmware in hda_intel.c Takashi Iwai
2012-08-09 14:26 ` Thierry Reding
2012-08-09 13:11 ` [PATCH 2/2] ALSA: hda - Deferred probing with request_firmware_nowait() Takashi Iwai
2012-08-09 13:26 ` David Henningsson
2012-08-09 13:32 ` Takashi Iwai
2012-08-09 13:36 ` [PATCH 2/2 v2] " Takashi Iwai
2012-08-09 13:54 ` David Henningsson
2012-08-09 14:04 ` Thierry Reding [this message]
2012-08-09 14:04 ` Takashi Iwai
2012-08-09 14:10 ` [PATCH 2/2 v3] " Takashi Iwai
2012-08-09 14:19 ` David Henningsson
2012-08-09 14:25 ` Thierry Reding
2012-08-09 14:34 ` Takashi Iwai
2012-08-09 14:38 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809140403.GA10145@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome