From: Jan Kara <jack@suse.cz>
To: Ashish Sangwan <ashishsangwan2@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org,
Ashish Sangwan <ashish.sangwan2@gmail.com>,
Namjae Jeon <linkinjeon@gmail.com>
Subject: Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize
Date: Tue, 14 Aug 2012 15:25:06 +0200 [thread overview]
Message-ID: <20120814132506.GB7122@quack.suse.cz> (raw)
In-Reply-To: <1342868717-1712-1-git-send-email-ashish.sangwan2@gmail.com>
On Sat 21-07-12 16:35:17, Ashish Sangwan wrote:
> If s_lvid_bh is not freed and set to NULL before re-scanning partition
> with default block size, we might end up using wrong lvid in case
> s_lvid_bh is not updated in udf_load_logicalvolint during rescan.
>
> Signed-off-by: Ashish Sangwan <ashish.sangwan2@gmail.com>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Yeah, I don't think this happens in practice but in theory it could. BTW,
did you check whether we don't need to free other information (like VAT
inode etc.) when rescanning the filesystem? I think we do but currently I'm
catching up after a long vacation and this doesn't have high priority.
Anyway, I've added your patch to my tree. Thanks.
Honza
>
> ---
> fs/udf/super.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index ac8a348..4a95c56 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -1961,6 +1961,8 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
> if (!silent)
> pr_notice("Rescanning with blocksize %d\n",
> UDF_DEFAULT_BLOCKSIZE);
> + brelse(sbi->s_lvid_bh);
> + sbi->s_lvid_bh = NULL;
> uopt.blocksize = UDF_DEFAULT_BLOCKSIZE;
> ret = udf_load_vrs(sb, &uopt, silent, &fileset);
> }
> --
> 1.7.2.3
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-08-14 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 11:05 Ashish Sangwan
2012-08-12 4:03 ` Namjae Jeon
2012-08-14 13:25 ` Jan Kara [this message]
2012-08-15 4:44 ` Ashish Sangwan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814132506.GB7122@quack.suse.cz \
--to=jack@suse.cz \
--cc=ashish.sangwan2@gmail.com \
--cc=ashishsangwan2@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®