mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH] usb: hcd: use *resource_size_t* for specifying resource data
Date: Thu, 16 Aug 2012 15:56:08 +0300	[thread overview]
Message-ID: <20120816125607.GB26408@arwen.pp.htv.fi> (raw)
In-Reply-To: <1345121659-24873-1-git-send-email-kishon@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

Hi,

On Thu, Aug 16, 2012 at 06:24:19PM +0530, Kishon Vijay Abraham I wrote:
> Changed the type of rsrc_start and rsrc_len from u64 to resource_size_t
> so that it behaves well with resource API's like *resource_size()* on both
> 32bit and 64bit devices.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

looks correct to me. FWIW:

Acked-by: Felipe Balbi <balbi@ti.com>

> ---
>  include/linux/usb/hcd.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c5fdb14..608050b 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -135,8 +135,8 @@ struct usb_hcd {
>  
>  	unsigned int		irq;		/* irq allocated */
>  	void __iomem		*regs;		/* device memory/io */
> -	u64			rsrc_start;	/* memory/io resource start */
> -	u64			rsrc_len;	/* memory/io resource length */
> +	resource_size_t		rsrc_start;	/* memory/io resource start */
> +	resource_size_t		rsrc_len;	/* memory/io resource length */
>  	unsigned		power_budget;	/* in mA, 0 = no limit */
>  
>  	/* bandwidth_mutex should be taken before adding or removing
> -- 
> 1.7.9.5
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-08-16 13:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 12:54 Kishon Vijay Abraham I
2012-08-16 12:56 ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120816125607.GB26408@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®