From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: "Fengguang Wu" <fengguang.wu@intel.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Oliver Neukum" <oneukum@suse.de>,
"Sarah Sharp" <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Lan, Tianyu" <tianyu.lan@intel.com>
Subject: Re: BUG: unable to handle kernel paging request in usb_match_id()
Date: Fri, 17 Aug 2012 06:45:54 -0700 [thread overview]
Message-ID: <20120817134554.GC2124@kroah.com> (raw)
In-Reply-To: <CACVXFVO0TYHP0=GZVo1cz_FdxXSbX-xQ8vwrwUrZ2Y0nj7yDzg@mail.gmail.com>
On Fri, Aug 17, 2012 at 08:16:15PM +0800, Ming Lei wrote:
> On Fri, Aug 17, 2012 at 6:24 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
> > On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote:
> >> Hi Bjørn,
> >>
> >> > -static const struct usb_device_id id_table[] __devinitconst = {
> >> > +static const struct usb_device_id id_table[] = {
> >>
> >> Good catch! It magically fixed the oops. So that id_table was
> >> freed sometime with __devinitconst?
> >>
> >> There are some more "usb_device_id .* __devinitconst" users in the system,
> >> Shall they be fixed as well?
>
> The issue should be triggered only when HOTPLUG is not set.
>
> But, if HOTPLUG is not enabled, should device_add() trigger driver probe
> further after kernel init is completed? Or even devices should be allowed
> to add into system?
Yes, it can, and should, because you can add them through sysfs.
I'll go fix these up, I really hate the __devinit* markings, they really
are pointless these days, and only cause problems :(
Thanks all for tracking this down.
greg k-h
next prev parent reply other threads:[~2012-08-17 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 2:59 Fengguang Wu
2012-08-05 16:58 ` Greg Kroah-Hartman
2012-08-17 2:00 ` Fengguang Wu
2012-08-17 3:48 ` Greg Kroah-Hartman
2012-08-17 5:44 ` Fengguang Wu
2012-08-17 8:52 ` Bjørn Mork
2012-08-17 9:07 ` Bjørn Mork
2012-08-17 9:27 ` Fengguang Wu
2012-08-17 10:24 ` Fengguang Wu
2012-08-17 12:16 ` Ming Lei
2012-08-17 13:45 ` Greg Kroah-Hartman [this message]
2012-08-17 14:38 ` Alan Stern
2012-08-17 14:42 ` Greg Kroah-Hartman
2012-08-18 0:58 ` Ming Lei
2012-08-19 10:23 ` Bjørn Mork
2012-08-19 14:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120817134554.GC2124@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn@mork.no \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tianyu.lan@intel.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome