From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Avi Kivity <avi@redhat.com>, Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Kevin Hilman <khilman@ti.com>,
Max Krasnyansky <maxk@qualcomm.com>,
Peter Zijlstra <peterz@infradead.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sven-Thorsten Dietrich <thebigcorporation@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Status of adaptive tickless patchset as of august 2012
Date: Sat, 18 Aug 2012 07:46:59 -0700 [thread overview]
Message-ID: <20120818144659.GB3533@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120818140248.GA16073@somewhere.redhat.com>
On Sat, Aug 18, 2012 at 04:02:51PM +0200, Frederic Weisbecker wrote:
> Hi,
>
> I started working on the adaptive nohz patchset by the end of 2010. Since then, I
> iterated through one big branch:
>
> - Nohz tasks (https://lwn.net/Articles/420490/)
> - Nohz cpusets (https://lwn.net/Articles/455044/)
> - Nohz cpusets v2 (https://lwn.net/Articles/487599/)
> - Nohz cpusets v3 (https://lwn.net/Articles/495422/)
>
> It quickly grew up to more than 40 patches. And still the full support
> (ie: handle everything that the tick maintains, but without the tick) wasn't
> yet finished.
>
> And the more I was progressing to get this full support, the more I had patches to
> maintain, rebase, improve, etc...
>
> Some side effects went to increase:
>
> - I had deep reviews about the core overall design in the first iterations. Thanks
> to that I made nice progresses. But as the patchset grew, I got less reviews about
> overall design but more about details. And I can totally understand that. Huge pile
> of patches certainly don't encourage reviews.
>
> - Lacking reviews on the overall design, I was feeling more and more uncomfortable about
> whatever I was improving or whichever feature I was adding on top of the existing ones.
> And I was indeed digging on some wrong direction for some parts.
>
> - I was spending too much time in out-of-tree maintainance while my goal is to get this
> upstream.
>
> All in one, this big branch neither scaled in term of reviews nor development.
>
> So I decided, after Ingo proposed me to set a tree in -tip, to cut all of the things the
> tick is handling and isolate each of these into single separate topics and handle them
> individually or at least iteratively, trying to push the things upstream or in a staging
> tree in -tip piecewise. As long as this is carried by concerned maintainers and I can get
> their insights on a regular basis. And also as long as we can iterate to some central branch
> because, even if we can cut out things into individual topics, there are significant interdependencies.
>
> I think this has been successfull so far:
>
> - The detection of illegal RCU read side critical sections under RCU extended quiescent
> state is now upstream. This even helped finding lot of bugs upstream.
>
> - State of user as RCU extended quiescent state is currently pending in Paul's tree
> in the rcu/idle branch. It's also in linux-next. This may likely go upstream or in
> a staging branch in -tip for the next merge window.
Indeed, the current plan is to push it for 3.7. ;-)
Thanx, Paul
> - Some preparatory work to split nohz and idle logic in nohz API. It went upstream
> on the last merge window.
>
> - Proposed something to handle nohz cputime accounting: https://lwn.net/Articles/501766/
> Got fundamental reviews that pointed me to rather reuse virtual based cputime accounting.
>
> - Consolidated/cleaned up virtual based cputime accounting (last version is
> https://lkml.org/lkml/2012/8/17/326 and waits for inclusion in -tip or so.)
>
> - On top of that vtime consolidation and the RCU pending patches, propose
> a generic virtual cputime accounting for archs that don't have CONFIG_VTIME_CPU_ACCOUNTING.
> See http://comments.gmane.org/gmane.linux.kernel/1337690
> A tickless CPU can then account cputime with that.
>
> So the process seem to be in a better direction now. Summer holidays have naturally made it a
> bit smoother and the rythm will probably stay that way until the end of ksummit/linuxcon/LPC. But
> I have the feeling we are moving forward.
>
> No schedule plans, but once I get the above topics sorted out, I'll probably work on timekeeping
> handling in adaptive tickless CPUs. And then the rest...
>
> I'll still keep maintaining the big branch in my tree. But this is now going to be rather a big draft or
> laboratory, with regular rebases on what is merged upstream or in maintainers tree. It helps me to
> keep a practical view of the big picture.
>
> Thanks.
>
prev parent reply other threads:[~2012-08-18 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 14:02 Frederic Weisbecker
2012-08-18 14:46 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120818144659.GB3533@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=abogani@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=hpa@zytor.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shemminger@vyatta.com \
--cc=tglx@linutronix.de \
--cc=thebigcorporation@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome