From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767Ab2HRU1n (ORCPT ); Sat, 18 Aug 2012 16:27:43 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:46226 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108Ab2HRU1k (ORCPT ); Sat, 18 Aug 2012 16:27:40 -0400 From: "Rafael J. Wysocki" To: Ming Lei Subject: Re: [PATCH v1 2/3] PM / Sleep: introduce dpm_for_each_dev Date: Sat, 18 Aug 2012 22:33:36 +0200 User-Agent: KMail/1.13.6 (Linux/3.5.0+; KDE/4.6.0; x86_64; ; ) Cc: Linus Torvalds , "Greg Kroah-Hartman" , Borislav Petkov , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <1345212420-1707-1-git-send-email-ming.lei@canonical.com> <201208181538.59940.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201208182233.37188.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, August 18, 2012, Ming Lei wrote: > On Sat, Aug 18, 2012 at 9:38 PM, Rafael J. Wysocki wrote: > > > > My question was about the number of current users of it. Sorry for not > > being clear. > > Sorry for misunderstanding your question. > > > > > If there are no more anticipated users than the current only one, please > > drop the unused (void *) argument. We can always extend it in the future > > if need be and for now passing that NULL every time is just pointless. > > One usage is to get statistics info about devices for debug purpose, > so the parameter is needed to return something. So, what's the name of the _second_ function using dpm_for_each_dev()? I don't see any and device_cache_fw_images() in [3/3] clearly passes NULL as the first argument. > > And please fold [2/3] into [3/3] in this series. > > IMO, it is better to split them to avoid coupling between fw loader and > device PM. > > Looks you agreed on the patch, On the idea, not on the actual code. I told you what I wanted to to change in it, didn't I? > and Greg has added the > patch into his driver-core next tree to fix -next build failure, so could > you just let them be that? -next is not cast in stone, you can replace patches in it with other ones if need be. Thanks, Rafael