From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: Build usb_speed_string unconditionally
Date: Mon, 20 Aug 2012 13:49:44 -0700 [thread overview]
Message-ID: <20120820204944.GA19667@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1208201639050.1182-100000@iolanthe.rowland.org>
On Mon, Aug 20, 2012 at 04:42:44PM -0400, Alan Stern wrote:
> On Mon, 20 Aug 2012, Andi Kleen wrote:
>
> > On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
> > > On Mon, 20 Aug 2012, Andi Kleen wrote:
> > >
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > >
> > > > The usb core uses usb_speed_string(). But it's only selected
> > > > for USB_GADGET. Enable it unconditionally.
> > >
> > > What are you talking about? USB_COMMON isn't selected at all, but it
> > > does get built whenever USB or USB_GAGDET is enabled. From
> > > drivers/usb/Kconfig:
> >
> > Just trying to fix my LTO randconfigs.
> >
> > Here's a config that violated it on rc2.
>
> Okay, I see the problem. Your config has:
>
> # CONFIG_USB_SUPPORT is not set
> CONFIG_USB=m
>
> That combination should not be possible, because in
> drivers/usb/Kconfig, the definition of USB is inside an "if
> USB_SUPPORT" block.
>
> Runing "make oldconfig" shows that this happened because:
>
> warning: (MOUSE_APPLETOUCH && MOUSE_BCM5974 && MOUSE_SYNAPTICS_USB && JOYSTICK_XPAD && TABLET_USB_ACECAD && TABLET_USB_AIPTEK && TABLET_USB_HANWANG && TABLET_USB_KBTAB && TABLET_USB_WACOM && TOUCHSCREEN_USB_COMPOSITE && INPUT_ATI_REMOTE2 && INPUT_KEYSPAN_REMOTE && INPUT_POWERMATE && INPUT_YEALINK && INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 && IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD)
>
> The culprit is DRM_USB, and I think Greg has just accepted a patch to
> fix it.
Yes, it's now in Linus's tree.
Andi, care to try this again with this .config on Linus's tree to see if
it all now works properly?
thanks,
greg k-h
next prev parent reply other threads:[~2012-08-20 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 19:38 Andi Kleen
2012-08-20 19:47 ` Alan Stern
2012-08-20 19:58 ` Andi Kleen
2012-08-20 20:27 ` Randy Dunlap
2012-08-20 20:42 ` Alan Stern
2012-08-20 20:49 ` Greg KH [this message]
2012-08-20 21:27 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820204944.GA19667@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome