From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
team-fjord@googlegroups.com
Subject: Re: [PATCH] tty: Added a CONFIG_TTY option to allow removal of TTY
Date: Tue, 21 Aug 2012 14:20:47 +0100 [thread overview]
Message-ID: <20120821142047.777e4bb0@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1345499431-21658-1-git-send-email-jmillenbach@gmail.com>
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -53,7 +53,7 @@ source "drivers/tty/serial/Kconfig"
>
> config TTY_PRINTK
> bool "TTY driver to output user messages via printk"
> - depends on EXPERT
> + depends on EXPERT && TTY
A lot of these could be done better with an if I think - notably the
serial one and perhaps some of the input ones if the tty users were
bunched together.
> config MOUSE_PS2
> tristate "PS/2 mouse"
> + depends on TTY
It shouldn't. It would be good to understand why this occurs.
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 5dbb3cb..c1406e3 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -377,7 +377,12 @@ extern void tty_write_flush(struct tty_struct *);
>
> extern struct ktermios tty_std_termios;
>
> +#ifdef CONFIG_TTY
> extern void console_init(void);
> +#else
> +static inline void console_init(void)
> +{ }
> +#endif
Please can you bunch the whole lot up into one #if defined() / #else /
#endif
rather than lots.
Otherwise this looks very sensible to me.
next prev parent reply other threads:[~2012-08-21 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 21:50 Joe Millenbach
2012-08-21 13:20 ` Alan Cox [this message]
[not found] ` <CADwDc1AvCvWbj8znN-1WbkZA9WYVAqaTkxi7+ENZfJ-qFNRAvw@mail.gmail.com>
2012-08-24 1:14 ` Fwd: " Joe Millenbach
2012-08-24 13:15 ` Alan Cox
2012-08-24 17:03 ` Josh Triplett
2012-08-24 17:12 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821142047.777e4bb0@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmillenbach@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=team-fjord@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®