From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539Ab2IAR0Z (ORCPT ); Sat, 1 Sep 2012 13:26:25 -0400 Received: from one.firstfloor.org ([213.235.205.2]:42303 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761Ab2IAR0Y (ORCPT ); Sat, 1 Sep 2012 13:26:24 -0400 Date: Sat, 1 Sep 2012 19:26:23 +0200 From: Andi Kleen To: Andi Kleen Cc: Michal Marek , linux-kernel@vger.kernel.org, x86@kernel.org, linux-kbuild@vger.kernel.org, JBeulich@suse.com, akpm@linux-foundation.org, Andi Kleen Subject: Re: [PATCH 44/74] lto: Mark functions used by the vsyscall init code visible Message-ID: <20120901172623.GO16230@one.firstfloor.org> References: <1345345030-22211-1-git-send-email-andi@firstfloor.org> <1345345030-22211-45-git-send-email-andi@firstfloor.org> <5042291E.6050602@suse.cz> <20120901171645.GN16230@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120901171645.GN16230@one.firstfloor.org> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 01, 2012 at 07:16:45PM +0200, Andi Kleen wrote: > > I think that there should be a comment why the symbol needs to be > > visible (just copy the reasoning from the changelog). Otherwise someone > > might attempt to do a cleanup a few years later, noticing that there is > > no assembler code calling get_random_int(). > > Ok. On hindsight maybe it's better to split vsyscall_64.c into two > files, one only with the vsyscall code and another with the init code. Or checking the code again it's already done because only the emulation is left and that is already a separate file. I'll drop those patches. -Andi -- ak@linux.intel.com -- Speaking for myself only.