From: Will Deacon <will.deacon@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Axel Lin <axel.lin@gmail.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: ux500: Fix build error due to missing include of asm/pmu.h in cpu-db8500.c
Date: Mon, 3 Sep 2012 14:38:39 +0100 [thread overview]
Message-ID: <20120903133839.GC31542@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <CACRpkdYxYGa=C092rbTU5bo=YEu6wqiTUD7W4pLS_wNfmAe4Zw@mail.gmail.com>
On Mon, Sep 03, 2012 at 11:47:51AM +0100, Linus Walleij wrote:
> On Sun, Sep 2, 2012 at 2:25 PM, Axel Lin <axel.lin@gmail.com> wrote:
>
> > Include asm/pmu.h to fix below build error:
> >
> > CC arch/arm/mach-ux500/cpu-db8500.o
> > arch/arm/mach-ux500/cpu-db8500.c:118:8: error: variable 'db8500_pmu_platdata' has initializer but incomplete type
> > arch/arm/mach-ux500/cpu-db8500.c:119:2: error: unknown field 'handle_irq' specified in initializer
> > arch/arm/mach-ux500/cpu-db8500.c:119:2: warning: excess elements in struct initializer [enabled by default]
> > arch/arm/mach-ux500/cpu-db8500.c:119:2: warning: (near initialization for 'db8500_pmu_platdata') [enabled by default]
> > make[1]: *** [arch/arm/mach-ux500/cpu-db8500.o] Error 1
> > make: *** [arch/arm/mach-ux500] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> That's on linux-next not on v3.6-rcN right?
>
> I've applied it to my ux500 branch and will carry it unless Will Deacon
> express an interest in it, PMU is his territory...
I've already sent a pull for those patches, so please can you carry the
fixup? u8500 is the only platform using the arm_pmu_platdata at the moment
so it has to keep the include.
Cheers,
Will
next prev parent reply other threads:[~2012-09-03 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 12:25 Axel Lin
2012-09-03 10:47 ` Linus Walleij
2012-09-03 11:40 ` Axel Lin
2012-09-03 13:38 ` Will Deacon [this message]
2012-09-03 14:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903133839.GC31542@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®