From: Andi Kleen <andi@firstfloor.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove bogus memcpy in brcm80211 ai_detach
Date: Mon, 3 Sep 2012 21:57:00 +0200 [thread overview]
Message-ID: <20120903195700.GZ16230@one.firstfloor.org> (raw)
In-Reply-To: <50450388.6040506@lwfinger.net>
On Mon, Sep 03, 2012 at 02:22:48PM -0500, Larry Finger wrote:
> On 09/03/2012 02:13 PM, Andi Kleen wrote:
> >gcc 4.8 warns for this memcpy. While the copy size is correct, the whole
> >copy seems to be a nop because the destination is never used, and
> >there's no need to use memcpy to copy pointers anyways. And the
> >type of the pointer was wrong, but at least those are always the same.
> >
> >Just remove it.
>
> Andi,
>
> Have you compiled all of wireless with gcc 4.8? If so, can I assume that
> you will report warnings for other drivers?
I did 64bit allyesconfig with LTO yes. wireless has very few warnings overall,
compared to many other subsystems.
I found one other issue in it for which I'm sending a patch.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-09-03 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 19:13 Andi Kleen
2012-09-03 19:22 ` Larry Finger
2012-09-03 19:57 ` Andi Kleen [this message]
2012-09-03 20:03 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903195700.GZ16230@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Larry.Finger@lwfinger.net \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®