From: David Miller <davem@davemloft.net>
To: fengguang.wu@intel.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i825xx: fix paging fault on znet_probe()
Date: Tue, 04 Sep 2012 15:13:06 -0400 (EDT) [thread overview]
Message-ID: <20120904.151306.1766477429185359707.davem@davemloft.net> (raw)
In-Reply-To: <20120902072546.GA20290@localhost>
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Sun, 2 Sep 2012 15:25:46 +0800
> In znet_probe(), strncmp() may access beyond 0x100000 and
> trigger the below oops in kvm. Fix it by limiting the loop
> under 0x100000-8. I suspect the limit could be further decreased
> to 0x100000-sizeof(struct netidblk), however no datasheet at hand..
...
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
This also makes the code actually match the description in the comment
above the loop :-)
Applied, thanks.
prev parent reply other threads:[~2012-09-04 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 7:25 Fengguang Wu
2012-09-04 19:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904.151306.1766477429185359707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®