mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Flavio Leitner <fbl@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	WANG Cong <xiyou.wangcong@gmail.com>, Tejun Heo <tj@kernel.org>,
	ianfang.cn@gmail.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: kexec/kdump kernel fails to start
Date: Tue, 4 Sep 2012 16:17:37 -0300	[thread overview]
Message-ID: <20120904161737.358d51ad@obelix.rh> (raw)
In-Reply-To: <CAE9FiQUEHbDySWHWFj6kW=HGLR0vkbaJWRq+7kMMHGhBm8e08A@mail.gmail.com>

On Tue, 4 Sep 2012 12:02:00 -0700
Yinghai Lu <yinghai@kernel.org> wrote:

> On Tue, Sep 4, 2012 at 10:32 AM, Flavio Leitner <fbl@redhat.com> wrote:
> > Hi folks,
> >
> > I have system that no longer boots kdump kernel. Basically,
> >
> > # echo c > /proc/sysrq-trigger
> >
> > to dump a vmcore doesn't work. It just hangs after showing the usual
> > panic messages. I've bisected the problem and the commit introducing
> > the issue is the one below.
> >
> > Any idea?
> >
> > commit 722bc6b16771ed80871e1fd81c86d3627dda2ac8
> > Author: WANG Cong <xiyou.wangcong@gmail.com>  2012-03-05 20:05:13
> > Committer: Ingo Molnar <mingo@elte.hu>  2012-03-06 05:38:26
> > Parent: 550cf00dbc8ee402bef71628cb71246493dd4500 (Merge tag 'mmc-fixes-for-3.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc)
> > Child:  a6fca40f1d7f3e232c9de27c1cebbb9f787fbc4f (x86, tlb: Switch cr3 in leave_mm() only when needed)
> > Branches: master, remotes/origin/master
> > Follows: v3.3-rc6
> > Precedes: v3.5-rc1
> >
> >     x86/mm: Fix the size calculation of mapping tables
> >
> >     For machines that enable PSE, the first 2/4M memory region still uses
> >     4K pages, so needs more PTEs in this case, but
> >     find_early_table_space() doesn't count this.
> >
> >     This patch fixes it.
> >
> >     The bug was found via code review, no misbehavior of the kernel
> >     was observed.
> 
> maybe just revert the offending commit?

I don't know where the 4K pages were noticed. Here is the
dmesg output passing 'debug':

[    0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
[    0.000000] last_pfn = 0xbf800 max_arch_pfn = 0x400000000
[    0.000000] initial memory mapped : 0 - 20000000
[    0.000000] Base memory trampoline at [ffff880000098000] 98000 size 20480
[    0.000000] init_memory_mapping: 0000000000000000-00000000bf800000
[    0.000000]  0000000000 - 00bf800000 page 2M
[    0.000000] kernel direct mapping tables up to bf800000 @ 1fa00000-20000000
[    0.000000] init_memory_mapping: 0000000100000000-0000000440000000
[    0.000000]  0100000000 - 0440000000 page 2M
[    0.000000] kernel direct mapping tables up to 440000000 @ bdaab000-bf4bd000
[    0.000000] RAMDISK: 352c8000 - 3695c000

so, it appears that on my system, the pages are 2M.
I will try moving the extra accounting to be inside of CONFIG_X86_32.

fbl

  reply	other threads:[~2012-09-04 19:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 17:32 Flavio Leitner
2012-09-04 19:02 ` Yinghai Lu
2012-09-04 19:17   ` Flavio Leitner [this message]
2012-09-04 19:20     ` Yinghai Lu
2012-09-04 20:00       ` Flavio Leitner
2012-09-04 20:26       ` Flavio Leitner
2012-09-04 20:45         ` Yinghai Lu
2012-09-04 21:37           ` Flavio Leitner
2012-09-04 22:25             ` Yinghai Lu
2012-09-04 22:40               ` Flavio Leitner
2012-09-05  0:01               ` Flavio Leitner
2012-09-05  1:15                 ` Yinghai Lu
2012-09-05 13:46                   ` Flavio Leitner
2012-09-05 15:34 ` Cong Wang
2012-09-23 20:27   ` Dan Carpenter
2012-09-23 20:52     ` Yinghai Lu
2012-09-29  7:13       ` Ingo Molnar
2012-10-18  2:16         ` Dave Young
2012-10-18  6:33           ` Dave Young
2012-10-18 13:57             ` Cong Wang
2012-10-18 16:27             ` Flavio Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904161737.358d51ad@obelix.rh \
    --to=fbl@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ianfang.cn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tj@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®