From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758973Ab2IEQxs (ORCPT ); Wed, 5 Sep 2012 12:53:48 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:45083 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138Ab2IEQxr (ORCPT ); Wed, 5 Sep 2012 12:53:47 -0400 Date: Wed, 5 Sep 2012 17:58:10 +0100 From: Alan Cox To: "K. Y. Srinivasan" Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, ben@decadent.org.uk, thozza@redhat.com, dcbw@redhat.com Subject: Re: [PATCH 4/4] tools: hv: Parse /etc/os-release Message-ID: <20120905175810.60ee45c8@pyramind.ukuu.org.uk> In-Reply-To: <1346864553-30059-4-git-send-email-kys@microsoft.com> References: <1346864519-30020-1-git-send-email-kys@microsoft.com> <1346864553-30059-1-git-send-email-kys@microsoft.com> <1346864553-30059-4-git-send-email-kys@microsoft.com> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (!strcmp(buf, "NAME")) > + os_name = strdup(value); > + else if (!strcmp(buf, "VERSION_ID")) > + os_major = strdup(value); strdup can fail. The case where it leaks because NAME= occurs twice is harmless enough but the strdup ought to be checked or add an x_strdup() helper. Alan