From: Thierry Reding <thierry.reding@avionic-design.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, NeilBrown <neilb@suse.de>,
Benoit Cousson <b-cousson@ti.com>, Felipe Balbi <balbi@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: Move TWL6030 PWM driver to PWM framework
Date: Fri, 7 Sep 2012 15:17:48 +0200 [thread overview]
Message-ID: <20120907131748.GE29340@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <5044671F.2030303@ti.com>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Mon, Sep 03, 2012 at 11:15:27AM +0300, Peter Ujfalusi wrote:
> On 09/02/2012 01:40 PM, Thierry Reding wrote:
> > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> > index 5fbb2a6..1b1a789 100644
> > --- a/drivers/mfd/twl-core.c
> > +++ b/drivers/mfd/twl-core.c
> > @@ -638,6 +638,13 @@ add_children(struct twl4030_platform_data *pdata, unsigned irq_base,
> > return PTR_ERR(child);
> > }
> >
> > + if (IS_ENABLED(CONFIG_PWM_TWL6030)) {
>
> I think you should also check for the PMIC versions here before adding the child:
> if (IS_ENABLED(CONFIG_PWM_TWL6030) && twl_class_is_6030()) {
>
> To avoid loading the twl6030-pwm driver for twl4030 class.
Yes, that does make sense. I'll add it.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-07 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 10:40 [PATCH 0/2] mfd: twl: Move " Thierry Reding
2012-09-02 10:40 ` [PATCH 1/2] mfd: twl: Replace twl_has_*() macros by IS_ENABLED() Thierry Reding
2012-09-18 7:31 ` Peter Ujfalusi
2012-09-02 10:40 ` [PATCH 2/2] pwm: Move TWL6030 PWM driver to PWM framework Thierry Reding
2012-09-03 8:15 ` Peter Ujfalusi
2012-09-07 13:17 ` Thierry Reding [this message]
2012-09-03 8:11 ` [PATCH 0/2] mfd: twl: Move " Peter Ujfalusi
2012-09-07 13:19 ` Thierry Reding
2012-09-07 13:52 ` Peter Ujfalusi
2012-09-18 7:07 ` Thierry Reding
2012-09-18 7:32 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907131748.GE29340@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome