mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: scameron@beardog.cce.hp.com
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Fengguang Wu <wfg@linux.intel.com>,
	Mike Miller <mike.miller@hp.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH -mm] cciss: select CONFIG_CHECK_SIGNATURE
Date: Fri, 7 Sep 2012 09:29:18 -0500	[thread overview]
Message-ID: <20120907142918.GM3430@beardog.cce.hp.com> (raw)
In-Reply-To: <1347026211-10557-1-git-send-email-akinobu.mita@gmail.com>

On Fri, Sep 07, 2012 at 10:56:51PM +0900, Akinobu Mita wrote:
> The patch cciss-use-check_signature.patch in -mm tree introduced
> a build error:
> 
> drivers/built-in.o: In function `CISS_signature_present':
> drivers/block/cciss.c:4270: undefined reference to `check_signature'
> 
> Add missing CONFIG_CHECK_SIGNATURE to fix this issue.
> 

Ack.  

Same thing that was done for hpsa.

-- steve

> Reported-by: Fengguang Wu <wfg@linux.intel.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Fengguang Wu <wfg@linux.intel.com>
> Cc: Mike Miller <mike.miller@hp.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
> ---
>  drivers/block/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index f529407..f7de322 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -131,6 +131,7 @@ config BLK_CPQ_DA
>  config BLK_CPQ_CISS_DA
>  	tristate "Compaq Smart Array 5xxx support"
>  	depends on PCI
> +	select CHECK_SIGNATURE
>  	help
>  	  This is the driver for Compaq Smart Array 5xxx controllers.
>  	  Everyone using these boards should say Y here.
> -- 
> 1.7.11.4



      reply	other threads:[~2012-09-07 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 13:56 Akinobu Mita
2012-09-07 14:29 ` scameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907142918.GM3430@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome