From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <eag0628@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7 V6] workqueue: fix idle worker depletion
Date: Sat, 8 Sep 2012 23:30:31 -0700 [thread overview]
Message-ID: <20120909063031.GA15530@dhcp-172-17-108-109.mtv.corp.google.com> (raw)
In-Reply-To: <CACvQF53Y9vAp2Eh3+2X=fLPYwq-DeW1dXTMmGJwoLRW6Bt_9xQ@mail.gmail.com>
Hello, Lai.
On Sun, Sep 09, 2012 at 12:09:58PM +0800, Lai Jiangshan wrote:
> > mutex_lock(&pool->manager_mutex);
> > if (worker_maybe_bind_and_lock(worker))
> > worker_clr_flags(worker, WORKER_UNBOUND);
> > ret = true;
> >
>
>
> This code is correct. worker_maybe_bind_and_lock() can be called any time.
> but I like to call it only when it is really needed.
Ummm... that code is complex for no reason. It isn't easier to read
or better in any way. Given the recent exchanges, it seems our tastes
differ greatly. Can you please just refresh the two patches as
requested and repost them on top of for-3.6-fixes?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-09-09 6:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 17:12 [PATCH 0/7 V6] workqueue: fix hoplug things Lai Jiangshan
2012-09-08 17:12 ` [PATCH 1/7 V6] workqueue: ensure the wq_worker_sleeping() see the right flags Lai Jiangshan
2012-09-08 17:12 ` [PATCH 2/7 V6] workqueue: async idle rebinding Lai Jiangshan
2012-09-08 17:12 ` [PATCH 3/7 V6] workqueue: add manager pointer for worker_pool Lai Jiangshan
2012-09-08 17:12 ` [PATCH 4/7 V6] workqueue: fix idle worker depletion Lai Jiangshan
2012-09-08 17:40 ` Tejun Heo
2012-09-08 17:50 ` Lai Jiangshan
2012-09-08 17:53 ` Tejun Heo
2012-09-08 18:07 ` Lai Jiangshan
2012-09-08 18:11 ` Tejun Heo
2012-09-08 18:34 ` Lai Jiangshan
2012-09-08 19:02 ` Tejun Heo
2012-09-09 4:09 ` Lai Jiangshan
2012-09-09 6:30 ` Tejun Heo [this message]
2012-09-08 17:12 ` [PATCH 5/7 V6] workqueue: rename manager_mutex to assoc_mutex Lai Jiangshan
2012-09-08 17:12 ` [PATCH 6/7 V6] workqueue: new day don't need WORKER_REBIND for busy rebinding Lai Jiangshan
2012-09-08 17:12 ` [PATCH 7/7 V6] workqueue: remove WORKER_REBIND Lai Jiangshan
2012-09-08 17:27 ` [PATCH 0/7 V6] workqueue: fix hoplug things Lai Jiangshan
2012-09-08 17:34 ` Lai Jiangshan
2012-09-08 17:37 ` Tejun Heo
2012-09-08 17:46 ` Lai Jiangshan
2012-09-08 17:50 ` Tejun Heo
2012-09-08 17:51 ` Tejun Heo
2012-09-08 17:56 ` Lai Jiangshan
2012-09-08 17:59 ` Tejun Heo
2012-09-08 18:21 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120909063031.GA15530@dhcp-172-17-108-109.mtv.corp.google.com \
--to=tj@kernel.org \
--cc=eag0628@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®