From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755630Ab2IJNQf (ORCPT ); Mon, 10 Sep 2012 09:16:35 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:40994 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067Ab2IJNQb (ORCPT ); Mon, 10 Sep 2012 09:16:31 -0400 Date: Mon, 10 Sep 2012 09:16:03 -0400 From: Neil Horman To: "Srivatsa S. Bhat" Cc: Gao feng , eric.dumazet@gmail.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, mark.d.rustad@intel.com, john.r.fastabend@intel.com, lizefan@huawei.com Subject: Re: [PATCH] net, cgroup: Fix boot failure due to iteration of uninitialized list Message-ID: <20120910131603.GA29742@hmsreliant.think-freely.org> References: <20120719162532.23505.85946.stgit@srivatsabhat.in.ibm.com> <500CA599.6030907@cn.fujitsu.com> <20120723114057.GA16518@hmsreliant.think-freely.org> <504DB2EE.2030700@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <504DB2EE.2030700@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2012 at 02:59:18PM +0530, Srivatsa S. Bhat wrote: > On 07/23/2012 05:10 PM, Neil Horman wrote: > > On Mon, Jul 23, 2012 at 09:15:05AM +0800, Gao feng wrote: > >> 于 2012年07月20日 00:27, Srivatsa S. Bhat 写道: > >>> After commit ef209f15 (net: cgroup: fix access the unallocated memory in > >>> netprio cgroup), boot fails with the following NULL pointer dereference: > >>> > [...] > >>> Call Trace: > >>> [] cgroup_init_subsys+0x83/0x169 > >>> [] cgroup_init+0x36/0x119 > >>> [] start_kernel+0x3ba/0x3ef > >>> [] ? kernel_init+0x27b/0x27b > >>> [] x86_64_start_reservations+0x131/0x136 > >>> [] x86_64_start_kernel+0x103/0x112 > >>> RIP [] cgrp_create+0xf6/0x190 > >>> RSP > >>> CR2: 0000000000000698 > >>> ---[ end trace a7919e7f17c0a725 ]--- > >>> Kernel panic - not syncing: Attempted to kill the idle task! > >>> > >>> The code corresponds to: > >>> > >>> update_netdev_tables(): > >>> for_each_netdev(&init_net, dev) { > >>> map = rtnl_dereference(dev->priomap); <---- HERE > >>> > >>> > >>> The list head is initialized in netdev_init(), which is called much > >>> later than cgrp_create(). So the problem is that we are calling > >>> update_netdev_tables() way too early (in cgrp_create()), which will > >>> end up traversing the not-yet-circular linked list. So at some point, > >>> the dev pointer will become NULL and hence dev->priomap becomes an > >>> invalid access. > >>> > >>> To fix this, just remove the update_netdev_tables() function entirely, > >>> since it appears that write_update_netdev_table() will handle things > >>> just fine. > >> > >> The reason I add update_netdev_tables in cgrp_create is to avoid additional > >> bound checkings when we accessing the dev->priomap.priomap. > >> > >> Eric,can we revert this commit 91c68ce2b26319248a32d7baa1226f819d283758 now? > >> I think it's safe enough to access priomap without bound check. > >> > > > > I think its probably safe, yes, but lets leave it there for just a bit. Its not > > hurting anything, and I'd like to look into getting Srivatsa' patch in first. > > Hi Neil, > > Did you get around to look into this again? > I haven't looked at it specifically no, I apologize. That said I think the other changes that went in back in that time frame have had time to soak, and looking at the way we current update the priomap table, I think its safe for us to remove the update_netdev_table call and definition. If you repost your patch, I'll ack it. Thanks! Neil > Regards, > Srivatsa S. Bhat > >