From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, alan@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed
Date: Tue, 11 Sep 2012 00:24:49 +0100 [thread overview]
Message-ID: <20120911002449.3aa7728a@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1347313402-24606-2-git-send-email-tomas.winkler@intel.com>
On Tue, 11 Sep 2012 00:43:21 +0300
Tomas Winkler <tomas.winkler@intel.com> wrote:
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/misc/mei/mei_dev.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
> index 96d3e79..adb35fb 100644
> --- a/drivers/misc/mei/mei_dev.h
> +++ b/drivers/misc/mei/mei_dev.h
> @@ -140,7 +140,7 @@ enum mei_cb_major_types {
> struct mei_message_data {
> u32 size;
> unsigned char *data;
> -} __packed;
> +};
Explanation would be useful especially for this one. The others are
obvious although a one line comment would still be good form perhaps.
next prev parent reply other threads:[~2012-09-10 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 21:43 [char-misc-next 1/3] mei: add error messages for open count errors Tomas Winkler
2012-09-10 21:43 ` [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed Tomas Winkler
2012-09-10 23:24 ` Alan Cox [this message]
2012-09-10 21:43 ` [char-misc-next 3/3] mei: don't print buffer as a string Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911002449.3aa7728a@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®