From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355Ab2IKMPL (ORCPT ); Tue, 11 Sep 2012 08:15:11 -0400 Received: from shamrock.taprogge.org ([213.146.117.139]:55912 "EHLO shamrock.taprogge.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454Ab2IKMPJ convert rfc822-to-8bit (ORCPT ); Tue, 11 Sep 2012 08:15:09 -0400 X-Greylist: delayed 2128 seconds by postgrey-1.27 at vger.kernel.org; Tue, 11 Sep 2012 08:15:09 EDT Date: Tue, 11 Sep 2012 13:39:19 +0200 From: Jens Taprogge To: Samuel Iglesias =?iso-8859-1?Q?Gons=E1lvez?= Cc: Dan Carpenter , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, industrypack-devel@lists.sourceforge.net Subject: Re: [PATCH 08/20] Staging: ipack: Switch to 8MHz operation before reading ID. Message-ID: <20120911113919.GA7174@endeavour.taprogge.org> References: <1347267118-9580-1-git-send-email-siglesias@igalia.com> <1347267118-9580-8-git-send-email-siglesias@igalia.com> <20120911084818.GP19396@mwanda> <1347363066.4539.112.camel@fourier.local.igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1347363066.4539.112.camel@fourier.local.igalia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Content-Transfer-Encoding: 8BIT X-Anti-Spam: Skipped scanning; message comes from a trusted host. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2012 at 01:31:06PM +0200, Samuel Iglesias Gonsálvez wrote: > On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote: > > On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote: > > > From: Jens Taprogge > > > > > > Reading the ID space at 8 MHz is always supported. Most carriers will > > > boot up in 8MHz mode. Still, play it safe and ensure we are operating at > > > 8Mhz. > > > > > > Signed-off-by: Jens Taprogge > > > Signed-off-by: Samuel Iglesias Gonsálvez > > > --- > > > drivers/staging/ipack/ipack.c | 11 ++++++++--- > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c > > > index 4f3c945..95f56b8 100644 > > > --- a/drivers/staging/ipack/ipack.c > > > +++ b/drivers/staging/ipack/ipack.c > > > @@ -376,6 +376,9 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus, > > > dev_set_name(&dev->dev, > > > "ipack-dev.%u.%u", dev->bus_nr, dev->slot); > > > > > > + if (bus->ops->set_clockrate(dev, 8)) > > > + dev_warn(&dev->dev, "failed to switch to 8 MHz operation for reading of device ID.\n"); > > > + > > > ret = ipack_device_read_id(dev); > > > if (ret < 0) { > > > dev_err(&dev->dev, "error reading device id section.\n"); > > > @@ -384,9 +387,11 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus, > > > } > > > > > > /* if the device supports 32 MHz operation, use it. */ > > > - ret = bus->ops->set_clockrate(dev, dev->speed_32mhz ? 32 : 8); > > > - if (ret < 0) > > > - dev_err(&dev->dev, "failed to switch to 32 MHz operation.\n"); > > > + if (dev->speed_32mhz) { > > > + ret = bus->ops->set_clockrate(dev, 32); > > > + if (ret < 0) > > > + dev_err(&dev->dev, "failed to switch to 32 MHz operation.\n"); > > > + } > > > > Ah. Well done. That's what I suggested earlier. I think you > > should get rid of the ->speed_8mhz all together. > > I will do it in a follow-up patch. The rest of suggestions have been > integrated in the patches. I will submit the patches very soon. I have not seen any IPack V2 device yet. But since the ID space provides the 8MHz flag, it might be useful. On the other hand, we can still readd it when we see it. When you remove the flag, you can perhaps leave a comment in the code so that it is easy to re-enable. Best Regards, Jens