From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 03/20] Input: Make sure we follow all EV_KEY events
Date: Wed, 12 Sep 2012 22:19:28 -0700 [thread overview]
Message-ID: <20120913051928.GE17105@core.coreip.homeip.net> (raw)
In-Reply-To: <1346528835-363-4-git-send-email-rydberg@euromail.se>
On Sat, Sep 01, 2012 at 09:46:58PM +0200, Henrik Rydberg wrote:
> For some EV_KEY types, sending a larger-than-one value causes the
> input state to oscillate. This patch makes sure this cannot happen,
> clearing up the autorepeat bypass logic in the process.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/input.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index 8ebf116..4d64500 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -239,24 +239,30 @@ static void input_handle_event(struct input_dev *dev,
> break;
>
> case EV_KEY:
> - if (is_event_supported(code, dev->keybit, KEY_MAX) &&
> - !!test_bit(code, dev->key) != value) {
> + if (is_event_supported(code, dev->keybit, KEY_MAX)) {
> +
> + /* auto-repeat bypasses state updates */
> + if (value == 2) {
> + disposition = INPUT_PASS_TO_HANDLERS;
> + break;
> + }
> +
> + if (!!test_bit(code, dev->key) != !!value) {
>
> - if (value != 2) {
> __change_bit(code, dev->key);
> + disposition = INPUT_PASS_TO_HANDLERS;
> +
> if (value)
> input_start_autorepeat(dev, code);
> else
> input_stop_autorepeat(dev);
> }
> -
> - disposition = INPUT_PASS_TO_HANDLERS;
> }
> break;
>
> case EV_SW:
> if (is_event_supported(code, dev->swbit, SW_MAX) &&
> - !!test_bit(code, dev->sw) != value) {
> + !!test_bit(code, dev->sw) != !!value) {
>
> __change_bit(code, dev->sw);
> disposition = INPUT_PASS_TO_HANDLERS;
> @@ -283,7 +289,7 @@ static void input_handle_event(struct input_dev *dev,
>
> case EV_LED:
> if (is_event_supported(code, dev->ledbit, LED_MAX) &&
> - !!test_bit(code, dev->led) != value) {
> + !!test_bit(code, dev->led) != !!value) {
>
> __change_bit(code, dev->led);
> disposition = INPUT_PASS_TO_ALL;
> --
> 1.7.12
>
--
Dmitry
next prev parent reply other threads:[~2012-09-13 5:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 19:46 [PATCH v3 v3 00/20] Input and HID updates for 3.7 Henrik Rydberg
2012-09-01 19:46 ` [PATCH v3 01/20] Input: Break out MT data Henrik Rydberg
2012-09-13 5:15 ` Dmitry Torokhov
2012-09-13 17:58 ` Henrik Rydberg
2012-09-01 19:46 ` [PATCH v3 02/20] Input: Improve the events-per-packet estimate Henrik Rydberg
2012-09-13 5:16 ` Dmitry Torokhov
2012-09-01 19:46 ` [PATCH v3 03/20] Input: Make sure we follow all EV_KEY events Henrik Rydberg
2012-09-13 5:19 ` Dmitry Torokhov [this message]
2012-09-01 19:46 ` [PATCH v3 04/20] Input: Move autorepeat to the event-passing phase Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 05/20] Input: Send events one packet at a time Henrik Rydberg
2012-09-13 6:56 ` Dmitry Torokhov
2012-09-13 17:59 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 06/20] Input: evdev - Add the events() callback Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 07/20] Input: MT - Add flags to input_mt_init_slots() Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 08/20] Input: MT - Handle frame synchronization in core Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 09/20] Input: MT - Add in-kernel tracking Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 10/20] Input: MT - Get slot by key Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 11/20] Input: bcm5974 - only setup button urb for TYPE1 devices Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 12/20] Input: bcm5974 - Preparatory renames Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 13/20] Input: bcm5974 - Drop pressure and width emulation Henrik Rydberg
2012-09-13 6:57 ` Dmitry Torokhov
2012-09-13 18:41 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 14/20] Input: bcm5974 - Drop the logical dimensions Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 15/20] Input: bcm5974 - Convert to MT-B Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 16/20] HID: Only dump input if someone is listening Henrik Rydberg
2012-09-02 7:28 ` Jiri Kosina
2012-09-02 8:52 ` Henrik Rydberg
2012-09-03 13:17 ` Jiri Kosina
2012-09-06 20:57 ` Henrik Rydberg
2012-09-07 1:54 ` Ping Cheng
2012-09-07 12:52 ` Jiri Kosina
2012-09-10 19:02 ` Henrik Rydberg
2012-09-10 20:49 ` Jiri Kosina
2012-09-10 21:12 ` Dmitry Torokhov
2012-09-14 19:25 ` Henrik Rydberg
2012-09-15 15:33 ` Input and HID updates for 3.7, version 4 Henrik Rydberg
2012-09-18 11:29 ` Jiri Kosina
2012-09-18 16:19 ` Henrik Rydberg
2012-09-19 16:57 ` Dmitry Torokhov
2012-09-19 18:34 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 17/20] HID: Add an input configured notification callback Henrik Rydberg
2012-09-01 19:47 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 19/20] HID: hid-multitouch: Remove the redundant touch state Henrik Rydberg
2012-09-01 19:47 ` [PATCH 20/20] HID: hid-multitouch: Add missing contact count detection Henrik Rydberg
2012-09-03 12:59 ` Benjamin Tissoires
2012-09-03 17:07 ` Henrik Rydberg
2012-09-05 15:09 ` [PATCH v2 20/20] HID: hid-multitouch: Fix contact count on 3M panels Henrik Rydberg
2012-09-03 13:00 ` [PATCH v3 v3 00/20] Input and HID updates for 3.7 Benjamin Tissoires
2012-09-03 17:08 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913051928.GE17105@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome