From: Greg KH <greg@kroah.com>
To: Rene Buergel <rene.buergel@sohard.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
Date: Thu, 13 Sep 2012 22:03:28 -0700 [thread overview]
Message-ID: <20120914050328.GB21944@kroah.com> (raw)
In-Reply-To: <f7e8f1a4-fb32-4933-ba9d-81a2f1fb7ba8@shmail0>
On Thu, Sep 13, 2012 at 10:19:11PM +0200, Rene Buergel wrote:
> This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and
> adapts Makefiles and Kconfigs
>
> Signed-off-by: René Bürgel <rene.buergel@sohard.de>
> --
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 1bfcd02..1c63b54 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -244,3 +244,7 @@ config USB_YUREX
> To compile this driver as a module, choose M here: the
> module will be called yurex.
>
> +config USB_EZUSB
> + bool "Functions for loading firmware on EZUSB chips"
> + help
> + Say Y here if you need EZUSB device support.
> diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
> index 796ce7e..f1f7815 100644
> --- a/drivers/usb/misc/Makefile
> +++ b/drivers/usb/misc/Makefile
> @@ -11,6 +11,7 @@ obj-$(CONFIG_USB_CYPRESS_CY7C63) += cypress_cy7c63.o
> obj-$(CONFIG_USB_CYTHERM) += cytherm.o
> obj-$(CONFIG_USB_EMI26) += emi26.o
> obj-$(CONFIG_USB_EMI62) += emi62.o
> +obj-$(CONFIG_USB_EZUSB) += ezusb.o
> obj-$(CONFIG_USB_FTDI_ELAN) += ftdi-elan.o
> obj-$(CONFIG_USB_IDMOUSE) += idmouse.o
> obj-$(CONFIG_USB_IOWARRIOR) += iowarrior.o
> diff --git a/drivers/usb/misc/ezusb.c b/drivers/usb/misc/ezusb.c
> new file mode 100644
> index 0000000..867a3e1
> --- /dev/null
> +++ b/drivers/usb/misc/ezusb.c
Git should show this as a move, not as a "add a file and remove a file"
type patch. Are you generating it properly?
Also, why move it? Are there other modules that need to use it?
thanks,
greg k-h
next prev parent reply other threads:[~2012-09-14 5:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <785f10f2-79bc-4708-9c57-7b505d75f223@shmail0>
2012-09-13 20:12 ` [PATCH v2 0/4]: ezusb cleanup, FX2 support, firmware downloading support Rene Buergel
2012-09-13 20:14 ` [PATCH v2 1/4]: " Rene Buergel
2012-09-13 20:15 ` [PATCH v2 2/4]: add support for Cypress FX2LP Rene Buergel
2012-09-14 5:01 ` Greg KH
2012-09-13 20:17 ` [PATCH v2 3/4]: add functions for firmware download Rene Buergel
2012-09-13 20:19 ` [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc Rene Buergel
2012-09-14 5:03 ` Greg KH [this message]
2012-09-14 6:52 ` Rene Buergel
2012-09-14 10:04 ` Sebastian Andrzej Siewior
2012-09-14 6:55 ` Rene Buergel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914050328.GB21944@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rene.buergel@sohard.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome