From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759384Ab2INJfO (ORCPT ); Fri, 14 Sep 2012 05:35:14 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:58127 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759294Ab2INJfI (ORCPT ); Fri, 14 Sep 2012 05:35:08 -0400 Date: Fri, 14 Sep 2012 10:39:30 +0100 From: Alan Cox To: David Howells Cc: herbert@gondor.hengli.com.au, rusty@rustcorp.com.au, linux-crypto@vger.kernel.org, zohar@us.ibm.com, dmitry.kasatkin@intel.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/16] X.509: Add an ASN.1 decoder Message-ID: <20120914103930.1e16ad8b@pyramind.ukuu.org.uk> In-Reply-To: <20120913235005.3575.46218.stgit@warthog.procyon.org.uk> References: <20120913234802.3575.77103.stgit@warthog.procyon.org.uk> <20120913235005.3575.46218.stgit@warthog.procyon.org.uk> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Sep 2012 00:50:05 +0100 David Howells wrote: > Add an ASN.1 BER/DER/CER decoder. This uses the bytecode from the ASN.1 > compiler in the previous patch to inform it as to what to expect to find in the > encoded byte stream. The output from the compiler also tells it what functions > to call on what tags, thus allowing the caller to retrieve information. Why do this in the kernel.That appears to be completely insane. Can you prove it runs in a short bounded time for all inputs, has it been fuzz tested extensively ? This kind of crap belongs in user space. Parse it in userspace, pass same structures and objects to the kernel. Alan