From: Alasdair G Kergon <agk@redhat.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing
Date: Fri, 14 Sep 2012 19:28:28 +0100 [thread overview]
Message-ID: <20120914182828.GK15728@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1346970902-10931-2-git-send-email-koverstreet@google.com>
On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote:
> With the old code, when you allocate a bio from a bio pool you have to
> implement your own destructor that knows how to find the bio pool the
> bio was originally allocated from.
>
> This adds a new field to struct bio (bi_pool) and changes
> bio_alloc_bioset() to use it. This makes various bio destructors
> unnecessary, so they're then deleted.
>
> v6: Explain the temporary if statement in bio_put
This patch also silently reverts
commit 4d7b38b7d944a79da3793b6c92d38682f3905ac9
"dm: clear bi_end_io on remapping failure"
Why?
If it's intentional, please explain it in your patch header and
copy Hannes to reconsider the matter.
If it wasn't intentional, please reinstate it.
Alasdair
next prev parent reply other threads:[~2012-09-14 18:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 22:34 [PATCH v10 0/8] Block cleanups Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 1/8] block: Generalized bio pool freeing Kent Overstreet
2012-09-14 18:28 ` Alasdair G Kergon [this message]
2012-09-17 20:51 ` [dm-devel] " Kent Overstreet
2012-09-18 16:31 ` Alasdair G Kergon
2012-09-14 18:36 ` Alasdair G Kergon
2012-09-06 22:34 ` [PATCH v10 2/8] block: Ues bi_pool for bio_integrity_alloc() Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 4/8] block: Add bio_reset() Kent Overstreet
2012-09-07 1:34 ` Jens Axboe
2012-09-07 20:58 ` Kent Overstreet
2012-09-07 21:55 ` Jens Axboe
2012-09-07 22:06 ` Jens Axboe
2012-09-07 22:25 ` Kent Overstreet
2012-09-07 22:44 ` Jens Axboe
2012-09-07 23:14 ` [dm-devel] " Alasdair G Kergon
2012-09-07 23:25 ` Kent Overstreet
2012-09-06 22:34 ` [PATCH v10 5/8] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-09-06 22:35 ` [PATCH v10 6/8] block: Kill bi_destructor Kent Overstreet
2012-09-06 23:42 ` Tejun Heo
2012-09-06 22:35 ` [PATCH v10 7/8] block: Consolidate bio_alloc_bioset(), bio_kmalloc() Kent Overstreet
2012-09-06 23:45 ` Tejun Heo
2012-09-06 22:35 ` [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc() Kent Overstreet
2012-09-06 23:46 ` Tejun Heo
2012-09-14 21:50 ` [dm-devel] " Alasdair G Kergon
2012-09-17 20:42 ` Kent Overstreet
2012-09-18 16:15 ` Alasdair G Kergon
2012-09-06 23:48 ` [PATCH v10 0/8] Block cleanups Tejun Heo
2012-09-07 1:37 ` Jens Axboe
2012-09-07 20:44 ` Kent Overstreet
2012-09-11 4:43 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914182828.GK15728@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=koverstreet@google.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®