From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759865Ab2INSg0 (ORCPT ); Fri, 14 Sep 2012 14:36:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759631Ab2INSgY (ORCPT ); Fri, 14 Sep 2012 14:36:24 -0400 Date: Fri, 14 Sep 2012 19:36:10 +0100 From: Alasdair G Kergon To: Kent Overstreet Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Lars Ellenberg , Alasdair Kergon , Hannes Reinecke Subject: Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing Message-ID: <20120914183610.GL15728@agk-dp.fab.redhat.com> Mail-Followup-To: Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Jens Axboe , Lars Ellenberg , Alasdair Kergon , Hannes Reinecke References: <1346970902-10931-1-git-send-email-koverstreet@google.com> <1346970902-10931-2-git-send-email-koverstreet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346970902-10931-2-git-send-email-koverstreet@google.com> Organization: Red Hat UK Ltd. Registered in England and Wales, number 03798903. Registered Office: 64 Baker Street, 4th floor, London, W1U 7DF. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote: > With the old code, when you allocate a bio from a bio pool you have to > implement your own destructor that knows how to find the bio pool the > bio was originally allocated from. > This adds a new field to struct bio (bi_pool) and changes > bio_alloc_bioset() to use it. This makes various bio destructors > unnecessary, so they're then deleted. If you reinstate commit 4d7b38b7d944a79da3793b6c92d38682f3905ac9 "dm: clear bi_end_io on remapping failure", Acked-by: Alasdair Kergon for the device-mapper parts. Alasdair